forax / pro

A Java build tool that works seamlessly with modules
GNU General Public License v3.0
103 stars 15 forks source link

Extract and set version in module fixing process #38

Closed sormuras closed 6 years ago

sormuras commented 7 years ago

The modulefixer should extract the (raw) version string from the plain JAR it processes and set the extracted version into the generated module.

Sources of version strings:

forax commented 7 years ago

I believe the former is doable but the later requires to have the Maven information inside the jar There is no from the repository at the time the module-fixer is executed because the jar is downloaded by the resolver before. But maybe, you are thinking about a specific file which is inserted into the jar if it is built with Maven ?

sormuras commented 7 years ago

But maybe, you are thinking about a specific file which is inserted into the jar if it is built with Maven ?

Mh, no. There's none I know of.

For me (JUnit) it would suffice if a manifest attribute like Implementation-Version is extracted and used by the fixer.

forax commented 6 years ago

fixed in d5c271724dbc2f413d4390f0cd78d7462a0c2aab