search

forax / pro

A Java build tool that works seamlessly with modules
GNU General Public License v3.0
103 stars 15 forks source link

Add static file/path related helpers to Pro #42

Closed sormuras closed 6 years ago

sormuras commented 7 years ago

How about adding more commonly used file tools to Pro that are not part of the JDK Files support class?

forax commented 7 years ago

That's more or less what you have in FileHelper https://github.com/forax/pro/blob/master/src/main/java/com.github.forax.pro.helper/com/github/forax/pro/helper/FileHelper.java#L34 https://github.com/forax/pro/blob/master/src/main/java/com.github.forax.pro.helper/com/github/forax/pro/helper/FileHelper.java#L143

The later one can be used to copy files, like that: https://github.com/forax/pro/blob/master/src/main/java/com.github.forax.pro.bootstrap/com/github/forax/pro/bootstrap/Bootstrap.java#L126

So perhaps, a simplified version could be created in a new class of com.github.forax.pro. I'm reluctant to put them directly in Pro and would prefer people that does file copy/etc to at least import a different class.

forax commented 6 years ago

I close this issue as i still think that such helper methods should be in FileHelper and not in Pro.