search

forbole / cosmos-rust-wallet

A cosmos network key-signer buildable in WASM
Apache License 2.0
28 stars 6 forks source link

Fix https://github.com/forbole/cosmos-rust-wallet/issues/47 #63

Closed tlkahn closed 2 years ago

tlkahn commented 2 years ago

Goal

This is to fix the compiling failure issue reported here.

Extentions

There are some warnings. Anyone are free to submit fixes.

manu0466 commented 2 years ago

Hi @tlkahn thanks for the contribution. I don't get why you are conditionaly compiling some functions with the with-bitcoin feature, on my machine just bumping the version of the bitcoin crate to 0.27.1 is enough to compile the crw-wallet crate.

tlkahn commented 2 years ago

Hi @manu0466, thanks so much for getting back to me. My apologies for submit a bad branch. Please kindly see this #64.

Other than bump up the version, there are two minor updates. It seems that bitcoin slightly changed their API on PrivateKey and PublicKey.

manu0466 commented 2 years ago

@tlkahn I had see, I have changed some part to fix the problems. Tomorrow I will merge the changes