Allow users to set gas manually

[leobragaz]

While making a tx, users can't set the gas manually. This can lead to problems like this one:

I suggest to add a button "Set gas" directly on the extension to allow users to set it manually. I imagine something like this:

[kwunyeung]

@bragaz do you know which tx the user is trying to broadcast. We should have applied gas adjustment to the gas estimate before signing the tx. I'm wondering how much gas is needed for this tx.

Instead of setting a gas value directly, I would suggest showing the gas estimate and allow users to change the gas adjustment with a slider.

[leobragaz]

@kwunyeung most of the users are facing it while trying to claim rewards. So a withdraw-rewards / withdraw_all_rewards transaction. I've also registered some cases of this problem with the unbound transaction.

[kanniec826]

• requested no. of gas * min 1.5, user can adjust more than 1.5
• show the estimate gas fee

[nicoletting]

As discussed last time, I found 3 solutions for the UI: I think (C) is the most suitable and educative one, for serval reasons:

1. present concept that complex transactions require more gas and the wanted gas range
2. provide 3 buttons for user's daily practice but in the different definition -> "simple, medium, complex"
3. adjustable slider & enable input amount and adjust amount with [+], [-] button.

to review the prototype please visit here @kwunyeung @kanniec826

[kanniec826]

@nicoletting Personally I prefer A

[kanniec826]

Please add your planning poker estimate with ZenHub @nicoletting

[kanniec826]

Please add your planning poker estimate with ZenHub @calvinkei

[calvinkei]

actually do we still need to do this? the error is caused by gas fee rounding instead of insufficient gas. 1.5x should be more than enough and no user is reporting this issue again since the fix

[kwunyeung]

@calvinkei @nicoletting maybe this should be treated as a separate issue.

My concern is in case 1.5x is not enough in the gas estimate, there is still option to override the gas amount. So for this case, I prefer a more simple way to set the gas but not having 1.5, 1.6, 1.7 for choosing. Having these options are meaningless.

[nicoletting]

I've modified the UI and it is now ready: view prototype here

• click a "set gas" icon to expand the column
• enter gas
• drag the slider for gas adjustment
• the calculated fee will be updated

please change UI of delegate/ redeledate/ undelegate/ withdraw rewards/ send🙇🏻‍♀️ icon_edit_light icon_edit_dark