search

forc-db / ForC

Global Forest Carbon Database
https://forc-db.github.io/
Creative Commons Attribution 4.0 International
55 stars 24 forks source link

resolving duplicates when conflict in methods (conflict type = "M") #244

Open ValentineHerr opened 3 years ago

ValentineHerr commented 3 years ago

I open this issue after this conversation in Teams

image

[12:19 PM] Herrmann, Valentine in this example, those 2 records were said to be independent (old_conglicts = "I"), but now the script says we should only keep the second as the first one does not have a date associated to it. I think that is correct, right? ​[12:20 PM] Herrmann, Valentine My guess is that maybe the site name of plot name were previously different so the 2 records were not grouped together.

[12:25 PM] Teixeira, Kristina A. Okay, normally I'd say yes, go with the one with the date. But in this case I think I'd like the M to overrule the T. Does that go against what we've been doing? ​[12:26 PM] Teixeira, Kristina A. We could actually code this instance of M overruling the T: allometry 33 (Chave et al. 2014) should be preferred over allometry 2 (or 2.1, 2.2, 2.3, which are the older Chave allometries)

[12:30 PM] Herrmann, Valentine Hmm... that is something I would have to code in the other script, the one that resolves the duplicates... it is currently not looking at "M" at all. We would need to establish rules like that, but it may be tricky. I'll open a separate issue.

ValentineHerr commented 3 years ago

wait.... actually the second record would be kept (small "s"). so we are good to go.

Leaving this open for a little bit, in case we want to think of something like that. But it may not be necessary.