Closed teixeirak closed 4 years ago
@teixeirak - agreed that's old! I uploaded the metadata below. Does this match what you have? METADATA.docx
@CookPatton , that new file is not an exact match to what we have. I'd have to take some time to do an A-to-B comparison... A big discrepancy with the set of files that we have is that this metadata refers to a "measurements tab", whereas we have separate files for soil and "nonsoil_litter_CWD.csv" (which is kind of a funny name-- should we change to something like "biomass_CWD_litter"?)
Okay, I've updated the metadata to make sure everything matches (attached). There are a few changes to make. @ValentineHerr would you make these so I don't mess it up?
[x] 1. In "GROA literature.csv" would you delete columns "Code2" and "Count"? These are housekeeping variables that I included and that are not needed.
[x] 2. In "sitesf.csv" would you delete all columns after soil.classification (e.g., dinerstein and WorldClim ones)? These were not directly extracted from the literature, but tacked on based on geolocation. I think it best to stick to only those variables directly extracted.
[x] 3. Would you change the name of "sitesf.csv" to just "sites.csv"? (i.e. delete the "f")
[ ] 4. In "nonsoil_litter_CWD.csv" would you delete columns:
[x] citations.title (redundant with other datasheets)
[x] sites.sitename (redundant)
[x] measurements.notes (housekeeping notes for myself, not needed here)
[x] X (residual from R)
[ ] prior.duration (data too messy to ultimately include)
[x] sand.silt.clay (supplanted by separate, sand, silt, clay, texture columns)
[x] pH (data too messy to ultimately include).
[x] 5. Would you change the name of "nonsoil_litter_CWD.csv" to "biomass_litter_CWD.csv"?
[x] 6. Would you replace soil.csv with the attached file (soilforGithub.csv) and then rename the new one "soil.csv"?
Thanks, I just loaded this.
* Would you replace soil.csv with the attached file (soilforGithub.csv) and then rename the new one "soil.csv"?
@CookPatton , please send soilforGithub.csv (not attached).
I changed sitesf file name in this commit.
@CookPatton , please send soilforGithub.csv (not attached).
nevermind, I found the file.
I have made all the changes except for one:
I did not delete prior.duration
because it appears to be used in this code. I believe our script sticks it in plot history notes. While mess, I do think it's valuable info that we want to retain. @CookPatton - Perhaps it can be renamed something like "prior.disturbance.notes", which would seem to fit the content and excuse the fact that its messy?
also, @ValentineHerr , some of these changes should break the code (renamed files), but should hopefully all be very easy to fix.
Metadata is good to go. We will have to make some fixes in the code, but I will go ahead and close this issue.
@CookPatton ,
I hate to say this, but it looks like the metadata files (pdf and csv) are out of date.
Most noteably, I believe these were made before separating out soil and nonsoil.