forc-db / GROA

This repository houses data and code for the Global Reforestation Opportunity Assessment (GROA) led by Susan Cook-Patton of the Nature Conservancy.
Creative Commons Attribution 4.0 International
31 stars 10 forks source link

update metadata #20

Closed teixeirak closed 4 years ago

teixeirak commented 4 years ago

@CookPatton ,

I hate to say this, but it looks like the metadata files (pdf and csv) are out of date.

Most noteably, I believe these were made before separating out soil and nonsoil.

CookPatton commented 4 years ago

@teixeirak - agreed that's old! I uploaded the metadata below. Does this match what you have? METADATA.docx

teixeirak commented 4 years ago

@CookPatton , that new file is not an exact match to what we have. I'd have to take some time to do an A-to-B comparison... A big discrepancy with the set of files that we have is that this metadata refers to a "measurements tab", whereas we have separate files for soil and "nonsoil_litter_CWD.csv" (which is kind of a funny name-- should we change to something like "biomass_CWD_litter"?)

CookPatton commented 4 years ago

Okay, I've updated the metadata to make sure everything matches (attached). There are a few changes to make. @ValentineHerr would you make these so I don't mess it up?

CookPatton commented 4 years ago

METADATA 5 June 2020.docx

teixeirak commented 4 years ago

METADATA 5 June 2020.docx

Thanks, I just loaded this.

teixeirak commented 4 years ago
* Would you replace soil.csv with the attached file (soilforGithub.csv) and then rename the new one "soil.csv"?

@CookPatton , please send soilforGithub.csv (not attached).

teixeirak commented 4 years ago

I changed sitesf file name in this commit.

teixeirak commented 4 years ago

@CookPatton , please send soilforGithub.csv (not attached).

nevermind, I found the file.

teixeirak commented 4 years ago

I have made all the changes except for one:

I did not delete prior.duration because it appears to be used in this code. I believe our script sticks it in plot history notes. While mess, I do think it's valuable info that we want to retain. @CookPatton - Perhaps it can be renamed something like "prior.disturbance.notes", which would seem to fit the content and excuse the fact that its messy?

teixeirak commented 4 years ago

also, @ValentineHerr , some of these changes should break the code (renamed files), but should hopefully all be very easy to fix.

teixeirak commented 4 years ago

Metadata is good to go. We will have to make some fixes in the code, but I will go ahead and close this issue.