forc-db / Global_Productivity

Creative Commons Attribution 4.0 International
2 stars 0 forks source link

R2 comments #128

Closed beckybanbury closed 3 years ago

beckybanbury commented 3 years ago

Comments to address:

beckybanbury commented 3 years ago

@teixeirak what do you think about adding n, rsq and p values to the plots? For me, I'm a little worried that this will clutter the plots as it's 3 - 4 lines of additional information per plot if we do that.

N samples is the same across the majority of analyses + is presented in the summary table, so I think we could leave that out. I don't know how much information p values will add - the plots already show significant/non-significant relationships by dotted or solid lines (perhaps I could make that clearer in the captions) + I don't know what p values would add on top of that. I could perhaps add rsq (I think originally we did do this + took out rsq values) , or we could state rsq in the captions.

teixeirak commented 3 years ago

Yeah, I'm not sure how you this would even be possible. I'd just add a sentence to the legend referring the reader to appropriate tables for this info, and noting that dashed/solid lines indicate significance.

Keep in mind that the paper is officially accepted, not contingent upon changes. We just need to make the changes that we consider improvements.

beckybanbury commented 3 years ago

Thanks for clarifying!

I think I'm finished with these comments then - just made some minor changes. I've pushed the edits but I can't knit for some reason - are you able to knit please?

I'll have a final read through, but pretty much there with this - just the repo to sort!

teixeirak commented 3 years ago

Wonderful; thanks! I will look at it soon, and try to knit. I'm using a different laptop right now, though, as mine had to go in for repair.

teixeirak commented 3 years ago

Do we currently site the ERL review? It's on the verge of being accepted, so I think it's safe to add it. It would be nice to point readers to that.