forc-db / IPCC-EFDB-integration

Creative Commons Attribution 4.0 International
4 stars 3 forks source link

mapping script clean-up #10

Closed teixeirak closed 3 years ago

teixeirak commented 3 years ago

@ValentineHerr , here's a running list of small things to fix:

ValentineHerr commented 3 years ago

hmmm issue with citation is annoying... I think it is because the function that pulled those stops pulling names after x number of names, and filles the rest with "..." which is apparently a special character.

@teixeirak, should we have Teagan fill those with all co-authors or do you think it is best to keep those "..." (so that citations are not too long). In the later case it should be easy for me to replace the special character with actual 3 dots.

ValentineHerr commented 3 years ago

plot.ID should be fixed now

teixeirak commented 3 years ago

hmmm issue with citation is annoying... I think it is because the function that pulled those stops pulling names after x number of names, and filles the rest with "..." which is apparently a special character.

@teixeirak, should we have Teagan fill those with all co-authors or do you think it is best to keep those "..." (so that citations are not too long). In the later case it should be easy for me to replace the special character with actual 3 dots.

3 dots is fine.

teixeirak commented 3 years ago

@ValentineHerr , note that I've added a few items to the list at the top of this issue.

ValentineHerr commented 3 years ago

[ ] reorder/ re-categorize some variables (see two commits ForC-EFDB_mapping between ~5 and 5:30pm on 3/31)

This should be automatic when ForC-EFDB_mapping is edited accordingly. Let me know if you see that it is not.

ValentineHerr commented 3 years ago
  • currently we have, e.g., "biogeographic zone: North America". Let's be consistent with biogeographic zone vs continent. For this example (Panama), we'd want either "continent: North America" or "biogeographic zone: neotropics". I think continent would be better in this case, but I'm not sure where you're getting that or how the system would classify islands/ countries that span continents or include continent + island. If it's a good system, stick with that. Otherwise, let's send the biogeographic zones that we have in the sites table.

Currently biogeog in SITES is the continent.... I agree that we should have actual biogeographic zones.... do we have that map? I need to check an and add that to the SCRIPT that fills this type of info for SITES... but for now, I'll call it Continent. I'll create an issue in ForC about this.

teixeirak commented 3 years ago

@ValentineHerr , note new item above

teixeirak commented 3 years ago

@ValentineHerr , two more minor fixes above. I just realized that I think we'd regret not including info about the allometries applied, when available.

ValentineHerr commented 3 years ago

@teixeirak, for allometries, 2 questions:

teixeirak commented 3 years ago

Yes, I guess we should concatenate both, assuming they're different (sometimes same reference has more than one code). Yes, pleaase bring in full citation.

ValentineHerr commented 3 years ago

The following citation.ID in ALLOMETRY need full reference in CITATIONS

teixeirak commented 3 years ago

@ValentineHerr , are these completely missing from citations? Or just need a DOI?

ValentineHerr commented 3 years ago

need DOI and/or citation.citation and/or citation.language

teixeirak commented 3 years ago

Do you need any of those for this first batch?

ValentineHerr commented 3 years ago

Yes, need Niiyama_2010_eorb for Ngo_2013_csip

and FYI, here are all the references we need them for:

teixeirak commented 3 years ago

Hmmm... we don'nt seem to have Niiyama in here at all. I'll track it down.

teixeirak commented 3 years ago

The following citation.ID in ALLOMETRY need full reference in CITATIONS

I've asked @Troger4 to prioritize these (https://github.com/forc-db/ForC/issues/223).

teixeirak commented 3 years ago

@ValentineHerr , note addition above.

ValentineHerr commented 3 years ago

the date issue is because we some  "flux" were changed to "increment" and my script was not up to date with that.