create map figure for publication

forc-db / IPCC-EFDB-integration

Creative Commons Attribution 4.0 International

4 stars 3 forks source link

create map figure for publication #33

Closed teixeirak closed 2 years ago

teixeirak commented 2 years ago

@mawilliams99 and/or @ValentineHerr , for our publication, we'll want to include a global map showing locations with relevant data and data sent to EFDB. I think it would be best to have an underlay of the FAO ecozones (plus our normal forest cover map), as IPCC uses those a lot for classification.

Here's the current placeholder with a caption that tries to describe what I envision. There is, of course, room to adjust this to your vision/ what's practical, so please don't hesitate to suggest improvements.

teixeirak commented 2 years ago

We'll want all the figures for the paper in this folder. If it's easier, we can create in the main GitHub repo and copy them over here.

ValentineHerr commented 2 years ago

[x] do FAO and drop dominant Tree Type
[x] keep only variables relevant to EFDB, change to triangle if some data has been sent

ValentineHerr commented 2 years ago

[ ] add script creating the map to the CI in ForC, so it gets upadated when there is an update to master ForC (but it won't get updated when they are changes to this repo...)

teixeirak commented 2 years ago

@ValentineHerr , this is gorgeous! The one thing I'd change is to emphasize the sites with data sent to EFDB a little more, if possible: make sure they're always on top, maybe make the symbols bigger or give them a bold outline.

@mawilliams99 , any comments?

teixeirak commented 2 years ago

@mawilliams99 , one thing it would be helpful for you to do is fill in the FAO ecozone codes in the legend for this figure. They go here (currently line 328):

ValentineHerr commented 2 years ago

I made the triangles bigger and their outline in bold. But I feel that putting them in the foreground would cover too many of the circles. What do you think @teixeirak and @mawilliams99 ?

(I also corrected the legend, which was wrong for n records - I need to do that for the other maps too.)

teixeirak commented 2 years ago

Thanks! That helps. I personally would put them in the foreground and not worry about covering other sites. The main point illustrated here is that we have a lot of data/ broad coverage, but I think we really want to emphasize what's already in EFDB.

teixeirak commented 2 years ago

Looks great!

All that's left now is to fill in the legend with the codes, so I'll assign this issue to @mawilliams99.