forc-db / IPCC-EFDB-integration

Creative Commons Attribution 4.0 International
4 stars 3 forks source link

finish histogram for publication #34

Closed teixeirak closed 2 years ago

teixeirak commented 2 years ago

@mawilliams99 and @ValentineHerr ,

Madison started this histogram (thank you!) for her paper. Let's get this finished.

Here's the placeholder with a caption that tries to describe what I'd envision:

image

Again, there's plenty of room for creativity/ other suggestions here.

@mawilliams99 , are you hitting a sticking point on this? @ValentineHerr , I believe you still have some time on this project that we could use to get this worked out?

teixeirak commented 2 years ago

We'll want all the figures for the paper in this folder. If it's easier, we can create in the main GitHub repo and copy them over here.

ValentineHerr commented 2 years ago

@mawilliams99 where is your script for this figure?

@teixeirak, what should be on the x-axis?

teixeirak commented 2 years ago

The x-axis should be dominant vegetation types.

ValentineHerr commented 2 years ago

can you define relevant to EFDB? Is it what is EFDB_ready but not sent yet, or just everything that would be sent (according to our criterias) if we assumed everything had been reviewed and flagged as EFDB_ready? (which might be a stretch if, for example, ForC does not specify that the measurement is found in a figure or is calculated, etc...).

teixeirak commented 2 years ago

It's the latter, or more simply all of the records for the variables we send.

ValentineHerr commented 2 years ago

Does this look good? image

ValentineHerr commented 2 years ago

"relevant" is n records with variable name to provide to IPCC, that is not "suspected.duplicate" (in ForC_simplified) and for which we have citation and language (was easier to add code for histogram after that filter, I can change if necessary)

ValentineHerr commented 2 years ago

Do with FAO instead, using codes in https://www.fao.org/3/ad652e/ad652e10.htm

ValentineHerr commented 2 years ago
teixeirak commented 2 years ago

@ValentineHerr , overall this looks great!

image

Copied here for reference. Here are a few things I'd tweak:

ValentineHerr commented 2 years ago

new versions: image

teixeirak commented 2 years ago

Looks fantastic!

In panel A, could you please put "Broadleaf (mixed E/D)" to clarify why these are separate? And in panel C, could you please change Oceania to "Islands"? (Sorry, I realized that Oceania actually refers to a particular geographic region.)

teixeirak commented 2 years ago

Also, could you please save .csvs with these numbers so that @mawilliams99 can use them to fill in the results section?

ValentineHerr commented 2 years ago

Oceania is actually what is ForC. So I think we can leave it as is. don't you think?

teixeirak commented 2 years ago

Yes, it's okay. I verified in the sites table that all with that label are actually Oceania, whereas other islands are associated to continents (e.g., Puerto Rico is North America).

teixeirak commented 2 years ago

Perfect; thank you!