Closed teixeirak closed 2 years ago
We'll want all the figures for the paper in this folder. If it's easier, we can create in the main GitHub repo and copy them over here.
@mawilliams99 where is your script for this figure?
@teixeirak, what should be on the x-axis?
The x-axis should be dominant vegetation types.
can you define relevant to EFDB? Is it what is EFDB_ready but not sent yet, or just everything that would be sent (according to our criterias) if we assumed everything had been reviewed and flagged as EFDB_ready? (which might be a stretch if, for example, ForC does not specify that the measurement is found in a figure or is calculated, etc...).
It's the latter, or more simply all of the records for the variables we send.
Does this look good?
"relevant" is n records with variable name to provide to IPCC, that is not "suspected.duplicate" (in ForC_simplified) and for which we have citation and language (was easier to add code for histogram after that filter, I can change if necessary)
Do with FAO instead, using codes in https://www.fao.org/3/ad652e/ad652e10.htm
@ValentineHerr , overall this looks great!
Copied here for reference. Here are a few things I'd tweak:
new versions:
Looks fantastic!
In panel A, could you please put "Broadleaf (mixed E/D)" to clarify why these are separate? And in panel C, could you please change Oceania to "Islands"? (Sorry, I realized that Oceania actually refers to a particular geographic region.)
Also, could you please save .csvs with these numbers so that @mawilliams99 can use them to fill in the results section?
Oceania is actually what is ForC. So I think we can leave it as is. don't you think?
Yes, it's okay. I verified in the sites table that all with that label are actually Oceania, whereas other islands are associated to continents (e.g., Puerto Rico is North America).
Perfect; thank you!
@mawilliams99 and @ValentineHerr ,
Madison started this histogram (thank you!) for her paper. Let's get this finished.
Here's the placeholder with a caption that tries to describe what I'd envision:
Again, there's plenty of room for creativity/ other suggestions here.
@mawilliams99 , are you hitting a sticking point on this? @ValentineHerr , I believe you still have some time on this project that we could use to get this worked out?