search

forc-db / IPCC-EFDB-integration

Creative Commons Attribution 4.0 International
4 stars 3 forks source link

figure out problem with calculation of numbers of records #46

Closed teixeirak closed 1 year ago

teixeirak commented 1 year ago

This is in line 186 of ESSDmanuscript.rmd.

I'm currently getting 17, which is wrong. Reporting of this number at line 543 is also wrong.

teixeirak commented 1 year ago

There's also a problem with this math: "increment records totaled 9% of records sent, including 8.55% for aboveground biomass increments and 0.28% for organic horizon increments. "

teixeirak commented 1 year ago

This also seems to be wrong: "In terms of variables transferred, records were sent for 21 variables" (my quick count was 18)

teixeirak commented 1 year ago

This also seems to be wrong: "In terms of variables transferred, records were sent for 21 variables" (my quick count was 18)

This is fixed. The issue stemmed from grouping of closely related variables in the table.

teixeirak commented 1 year ago

This is in line 186 of ESSDmanuscript.rmd.

I'm currently getting 17, which is wrong. Reporting of this number at line 543 is also wrong.

This part of the problem was caused because I hadn't refreshed variables in my R session after the table had been updated.

teixeirak commented 1 year ago

There's also a problem with this math: "increment records totaled 9% of records sent, including 8.55% for aboveground biomass increments and 0.28% for organic horizon increments. "

This was just a rounding problem, now resolved.