search

force-h2020 / force-bdss-plugin-gromacs

Gromacs BDSS data sources, as well as a stand-alone wrappers around Gromacs tools.
MIT License
0 stars 0 forks source link

New IBaseProcess class #14

Closed flongford closed 4 years ago

flongford commented 5 years ago

This PR approaches #26 by introducing the IBaseProcess class, of type Interface that provides a basic set of functionalities, abstracted from for the BaseGromacsProcess class.

Subsequently, it allows for objects that can provide an interface to this class to be added to a GromacsPipeline, without needing to explicitly use the subprocess library. Examples within the codebase now include GromacsFileTreeWriter and GromacsTopologyWriter.

codecov-io commented 4 years ago

Codecov Report

Merging #14 into cln/refactor-generic will increase coverage by 4.29%. The diff coverage is 100%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           cln/refactor-generic      #14      +/-   ##
========================================================
+ Coverage                 94.56%   98.86%   +4.29%     
========================================================
  Files                        35       59      +24     
  Lines                       847     2115    +1268     
  Branches                    101      143      +42     
========================================================
+ Hits                        801     2091    +1290     
+ Misses                       32       10      -22     
  Partials                     14       14
Impacted Files Coverage Δ
...tion_listeners/hpc_writer/tests/test_hpc_writer.py 100% <ø> (ø)
force_gromacs/gromacs_plugin.py 100% <ø> (ø) :arrow_up:
...romacs/data_sources/simulation/simulation_model.py 96.29% <100%> (+0.46%) :arrow_up:
force_gromacs/io/gromacs_coordinate_reader.py 94.91% <100%> (ø) :arrow_up:
...ce_gromacs/core/tests/test_base_gromacs_command.py 100% <100%> (ø)
...es/simulation/tests/test_simulation_data_source.py 100% <100%> (ø)
.../data_sources/simulation/simulation_data_source.py 96.55% <100%> (+0.71%) :arrow_up:
...romacs/pipeline/base_gromacs_simulation_builder.py 96.15% <100%> (ø)
force_gromacs/tests/probe_classes.py 97.95% <100%> (ø)
...cs/notification_listeners/hpc_writer/hpc_writer.py 89.74% <100%> (ø) :arrow_up:
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c28c0b4...5f5abc4. Read the comment docs.