Closed flongford closed 5 years ago
Merging #47 into master will increase coverage by
4.48%
. The diff coverage is91.66%
.
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 73.6% 78.09% +4.48%
==========================================
Files 27 28 +1
Lines 557 557
Branches 38 30 -8
==========================================
+ Hits 410 435 +25
+ Misses 141 116 -25
Partials 6 6
Impacted Files | Coverage Δ | |
---|---|---|
itwm_example/mco/subprocess_workflow_evaluator.py | 100% <100%> (ø) |
|
itwm_example/mco/mco.py | 81.01% <62.5%> (+18.39%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3ee8db0...b27d62b. Read the comment docs.
This PR implements updates required by the refactoring of
force_bdss
in force-h2020/force-bdss/pull/232. It is very similar in content to force-h2020/force-bdss-plugin-enthought-example/pull/34It simplifies the
MCO
class by using the in built functionalities of the newWorkflowEvaluator
class, removing anyISinglePointEvaluator
subclasses.A new subclass
SubprocessWorkflowEvaluator
is also included to spawn a subprocess that calls anotherforce_bdss
executable to perform the same evaluation (current functionality implemented in bothforce-bdss-plugin-enthought-example
andforce-bdss-plugin-itwm-example
BaseMCO
subclasses).Note: this branch is pinned to
force-bdss/enh/refactor-factory-plugin
and should not be merged before force-h2020/force-bdss/pull/232 is closedChange Log
ISinglePointEvaluator
,InternalSinglePointEvaluator
andSubprocessSinglePointEvaluator
classes removedSubprocessWorkflowEvaluator
, which is a subclass ofWorkflowEvaluator
BaseMCO
subclassesrun
methods now expect aevaluator
argument, rather thanmodel
. These methods have also been amended to callevaluator.evaluate(<list of parameters>)
to calculate the KPIs at each data point.factory.plugin.id
references updated tofactory.plugin_id
factory.plugin.application
references removedKnown Issues
BaseMCO
class at least before merging