search

force-h2020 / force-bdss-plugin-itwm-example

ITWM Example plugin for the BDSS
0 stars 3 forks source link

Nevergrad parameters parser #57

Closed Corwinpro closed 4 years ago

Corwinpro commented 4 years ago

This PR implements _future_ features for all plugins using nevergrad as the optimization engine. The default ITWM RangedMCOParameter is also treated in this PR.

Summary

We implement a naive parser from:MCOParameter to:nevergrad.var objects. The mapping is based on the existing attributes of the parsed MCOParameter. The rule is:

Notes

So far, we can't handle vector parameters. This is also referenced in this close issue

The addition of an example workflow JSON file closes #43

codecov-io commented 4 years ago

Codecov Report

Merging #57 into master will increase coverage by 0.58%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   86.77%   87.35%   +0.58%     
==========================================
  Files          31       32       +1     
  Lines         756      791      +35     
  Branches       56       65       +9     
==========================================
+ Hits          656      691      +35     
  Misses         88       88              
  Partials       12       12
Impacted Files Coverage Δ
itwm_example/mco/optimizers/optimizers.py 95.03% <100%> (+0.96%) :arrow_up:
itwm_example/mco/scaling_tools/kpi_scaling.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bef6afa...f99d4ae. Read the comment docs.

flongford commented 4 years ago

Just a quick comment, could you provide an updated example workflow file in itwm_example/tests/fixtures (I don't think we have a fixtures directory for this plugin actually) - my current version is out of date. Many thanks