Closed Corwinpro closed 4 years ago
Merging #270 into dev/workflow-event will increase coverage by
0.02%
. The diff coverage is100%
.
@@ Coverage Diff @@
## dev/workflow-event #270 +/- ##
======================================================
+ Coverage 96.93% 96.95% +0.02%
======================================================
Files 54 54
Lines 1499 1511 +12
Branches 144 144
======================================================
+ Hits 1453 1465 +12
Misses 42 42
Partials 4 4
Impacted Files | Coverage Δ | |
---|---|---|
force_bdss/mco/base_mco_model.py | 100% <100%> (ø) |
:arrow_up: |
force_bdss/app/optimize_operation.py | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d5d6481...c671fb3. Read the comment docs.
This PR extends the changes introduced in #269 This PR approaches #247, and #333 of the WorkflowManager
Summary
We introduce
mco_events
types to theBaseMCOModel
class. Now developers are able to specify custom start, progress, and finish events in theMCOModel
: events of these types will be raised at runtime.notify_new_point
is not deprecated. Usenotify_progress_event
instead.Done
_start_event_type
,_progress_event_type
and_finish_event_type
to theBaseMCOModel
:create_event
methods of theBaseMCOModel
: not these are callednotify_*_event
and immediately callself.notify
method with an appropriate event.notify_progress_event
now accepts**kwargs
as the third parameter, instead ofweights
. This allows users and developers to propagate custom data to theMCOProgessEvent
s.notify_new_point
is now deprecated.