search

force-h2020 / force-bdss

Business Decision System general interface
BSD 2-Clause "Simplified" License
2 stars 2 forks source link

MAINT: Workflow backwards compatiblity #287

Closed Corwinpro closed 4 years ago

Corwinpro commented 4 years ago

This PR closes #271

Summary

We add a "version" specific rule in the WorkflowReader._preprocess_workflow_data() method, that expect the "mco" keyword in the workflow configuration file of "version": "1".

The workflow config files of version "1" use "mco" as the key to identify the mco model parameters, so we restore the ability to read old configuration file with "mco" instead of "mco_model".

codecov[bot] commented 4 years ago

Codecov Report

Merging #287 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   97.07%   97.08%   +<.01%     
==========================================
  Files          57       57              
  Lines        1575     1578       +3     
  Branches      152      153       +1     
==========================================
+ Hits         1529     1532       +3     
  Misses         42       42              
  Partials        4        4
Impacted Files Coverage Δ
force_bdss/io/workflow_reader.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b0546c...84943f8. Read the comment docs.

flongford commented 4 years ago

Note: This branch was successfully merged to master, though something happened to GitHub at the time and so the PR request was not updated successfully