search

force-h2020 / force-bdss

Business Decision System general interface
BSD 2-Clause "Simplified" License
2 stars 2 forks source link

Verification message two #328

Closed sparsonslab closed 4 years ago

sparsonslab commented 4 years ago

Closes #324.

Ported output/input slot error messages from ExecutionLayer.execute_layer() to BaseDataSourceModel.verify().

Did not remove tests from execute_layer() - that took me down a unit-test rabbit hole.

codecov[bot] commented 4 years ago

Codecov Report

Merging #328 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          60       60           
  Lines        1687     1689    +2     
  Branches      171      171           
=======================================
+ Hits         1658     1660    +2     
  Misses         24       24           
  Partials        5        5
Impacted Files Coverage Δ
force_bdss/data_sources/base_data_source_model.py 98.27% <100.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eba28aa...4422d9a. Read the comment docs.

flongford commented 4 years ago

@sparsonslab - Did you see #327?

sparsonslab commented 4 years ago

@sparsonslab - Did you see #327?

No I hadn't. I can incorporate that into this branch. (?)

flongford commented 4 years ago

@sparsonslab - Did you see #327?

No I hadn't. I can incorporate that into this branch. (?)

I think it should already solve the issues you had with #326

flongford commented 4 years ago

Closing in preference of #326