force-h2020 / force-bdss

Business Decision System general interface
BSD 2-Clause "Simplified" License
2 stars 2 forks source link

CLN: Interface classes #329

Closed flongford closed 4 years ago

flongford commented 4 years ago

Provides a clean up of Interface classes defined in the BDSS.

Generally removes some attributes or methods that are no longer needed by their corresponding base class implementations and includes others that are missing.

Does not change any functionality, only tidies up code base to accompany #311 and provides a minor unit test fix to maintain coverage.

codecov[bot] commented 4 years ago

Codecov Report

Merging #329 into master will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   98.33%   98.39%   +0.05%     
==========================================
  Files          60       60              
  Lines        1686     1685       -1     
  Branches      170      170              
==========================================
  Hits         1658     1658              
  Misses         23       23              
+ Partials        5        4       -1     
Impacted Files Coverage Δ
force_bdss/core/i_factory.py 100.00% <100.00%> (ø)
force_bdss/data_sources/i_data_source_factory.py 100.00% <100.00%> (ø)
force_bdss/mco/i_mco_factory.py 100.00% <100.00%> (ø)
..._bdss/mco/parameters/base_mco_parameter_factory.py 100.00% <100.00%> (ø)
...rce_bdss/mco/parameters/i_mco_parameter_factory.py 100.00% <100.00%> (ø)
...ation_listeners/i_notification_listener_factory.py 100.00% <100.00%> (ø)
force_bdss/ui_hooks/i_ui_hooks_factory.py 100.00% <100.00%> (ø)
force_bdss/mco/parameters/mco_parameters.py 100.00% <0.00%> (+0.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 460a028...393276d. Read the comment docs.