Closed flongford closed 4 years ago
Merging #416 into master will decrease coverage by
0.00%
. The diff coverage is96.98%
.
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
- Coverage 96.91% 96.91% -0.01%
==========================================
Files 52 51 -1
Lines 2756 2751 -5
Branches 345 347 +2
==========================================
- Hits 2671 2666 -5
- Misses 49 50 +1
+ Partials 36 35 -1
Impacted Files | Coverage Δ | |
---|---|---|
force_wfmanager/ui/review/curve_scatter_plot.py | 96.15% <91.66%> (-3.85%) |
:arrow_down: |
force_wfmanager/ui/review/scatter_plot.py | 95.77% <95.77%> (ø) |
|
force_wfmanager/ui/review/base_data_view.py | 97.95% <95.83%> (-2.05%) |
:arrow_down: |
force_wfmanager/ui/review/base_plot.py | 98.01% <98.01%> (ø) |
|
force_wfmanager/ui/__init__.py | 100.00% <100.00%> (ø) |
|
force_wfmanager/ui/review/data_view_pane.py | 100.00% <100.00%> (ø) |
|
force_wfmanager/version.py |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8f523ec...f6e6ad4. Read the comment docs.
Description
Refactors
BaseDataView
classes so that extension of chaco plot objects is easierRelated Issues
Closes #353
Summary
The main changes are
BaseDataView
class, with option to extend scheduled updates inupdate_data_view
methodBasePlot
class moved to its own module to become a generic 2D plot - subclasses can implement the optionalcustomize_plot
method to customize ChacoBaseXYPlot
components andcustomize_plot_data
method to provide new chacoArrayPlotData
components.Component
object being displayed in theBasePlot
TraitsUI view and the main plot that is hooked up to the MCO data. It is now possible to customize both, so that multiple chaco objects can be displayed in the sameBasePlot
viewPlot
class renamed asScatterPlot
with combined color optionsIBasePlot
classFuture Work
BaseDataView
could be turned into anABCHasStrictTraits
classMCORuntimeEvent
s, so that the data views components could be formatted accordingly.Changes
BaseDataView
classes to provide easier framework for extension