search

force-h2020 / force-wfmanager

Workflow manager: UI application for Business Decision System
Other
1 stars 0 forks source link

FIX: ScatterPlot not initializing with use_color_plot=True #417

Closed flongford closed 4 years ago

flongford commented 4 years ago

Description

An exception was being thrown when calling ScatterPlot(use_color_plot=True), which was caused by a trait listener that references self._plot_data being called before the init routine had assigned this trait.

Summary

Including the post_init=True metadata on the problem listener (ScatterPlot.change_plot_style) resolves this issue.

A unit test is also introduced to assert that the constructor can handle initializing ScatterPlot(use_color_plot=True)

Changes

codecov[bot] commented 4 years ago

Codecov Report

Merging #417 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files          51       51           
  Lines        2751     2751           
  Branches      347      347           
=======================================
  Hits         2666     2666           
  Misses         50       50           
  Partials       35       35
Impacted Files Coverage Δ
force_wfmanager/ui/review/scatter_plot.py 95.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc35e90...0ac3be3. Read the comment docs.