search

forcecore / yupgi_alert0

엽기얼럿 제로
Other
10 stars 3 forks source link

Compatibility for upstream bleed and AS #87

Closed jrb0001 closed 7 years ago

jrb0001 commented 7 years ago

These changes are needed to use yupgi_alert and https://github.com/GraionDilach/OpenRA.Mods.AS in the same mod while using bleed from upstream.

See also:

GraionDilach commented 7 years ago

This isn't enough alone.

Using Mods.AS with this project will result with something akin to the dll hell, due to some of the trait code of AS's being duplicated with the same name (ExplodeWeapon, GrantTimedConditionOnDeploy) which will shoot the trait-resolver in the head. Compilation will work, yes, but calling these duplicated traits when both dlls are included in the mod will certainly cause messups.

jrb0001 commented 7 years ago

@GraionDilach I removed ExplodeWeapon and GrantTimedConditionOnDeploy from yupgi_alert so there shouldn't be any conflict.

GraionDilach commented 7 years ago

Oh yes, you did. @forcecore, this PR massively changes your architecture, so beware of the aftereffects.

It also will prevent me of going the duplication way with y_a code, so yay.

jrb0001 commented 7 years ago

I am discussing the problem of depending on multiple soft-forks with @GraionDilach so it's probably a good idea to put this PR on hold for 1-2 weeks until we have a conclusion and everybody has time again.

forcecore commented 7 years ago

OK thank you very much. I am pleasantly surprised to have a PR for my mod :)

forcecore commented 7 years ago

Closing this PR, both yupgi_alert and AS has moved on and they are mutually taking modules from one another :) (and AS version has higher quality code)