search

forcecraft / aion

An e-learning platform written in Elixir and Elm based on real-time gameplay
6 stars 0 forks source link

enhancement(elixir): Move to phoenix v1.3 architecture #103

Open mrapacz opened 7 years ago

mrapacz commented 7 years ago

Type

Enhancement

Current behaviour Right now location of our models and logic is somewhat chaotic

Expected behaviour We could move to architecture suggested by newest Phoenix, which is model-based. The directory hierarchy would probably look like:

room/
 - room.ex
 - ecto.ex/schema.ex (whatever), it can also be in room/room.ex, not sure yet how to solve this
 - other files
room.ex <- a module providing an API for other modules

This is how lib folder looks after generating example phoenix project and generating a user ecto model: image

Motivation / use case

52

mrapacz commented 7 years ago

@pmrukot this change would require us to replace elm to lib/ too. What do you think about it?

pmrukot commented 7 years ago

I would wait with this change, I would say it is not a priority for now, we have more important things to do. I would polish the product, deploy it, add missing features and then reorganise structure to match Phoenix 1.3 architecture. I do not want to bother myself with this change since I consider us having more important stuff to do.

Why do you consider having this a high priority?

mrapacz commented 7 years ago

I was thinking about giving it a high priority as part of the elixir refactor task. I agree with you, so I'll just create the next milestone later and assign this issue as a part of it.

On niedz., 3 wrz 2017, 13:36 Patryk Mrukot notifications@github.com wrote:

I would wait with this change, I would say it is not a priority for now, we have more important things to do. I would polish the product, deploy it, add missing features and then reorganise structure to match Phoenix 1.3 architecture. I do not want to bother myself with this change since I consider us having more important stuff to do.

Why do you consider having this a high priority?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/forcecraft/aion/issues/103#issuecomment-326799556, or mute the thread https://github.com/notifications/unsubscribe-auth/APOb2wSSyaMMGMoeiwff1s0G5D_mSeUVks5seo9SgaJpZM4PLHe6 .