search

forcedotcom / ApexUnit

ApexUnit is a powerful continuous integration tool for the Force.com platform
BSD 3-Clause "New" or "Revised" License
71 stars 51 forks source link

Code cleanup. Cleaned up unnecessary null checks and unused parameters. #44

Closed glang closed 8 years ago

glang commented 8 years ago

Code cleanup. Cleaned up unnecessary null checks and unused parameters.

adarsh-ramakrishna-sfdc commented 8 years ago

@glang generateHTMLReportTest failed on Travis. Did you test this locally? and on the internal jenkins instance?

adarsh-ramakrishna-sfdc commented 8 years ago

As long as you confirm that all tests pass, 👍 from me

glang commented 8 years ago

@adarsh-ramakrishna-sfdc the generateHTMLReportTest is a strange one. It fails and passes randomly on Travis as far as I can tell. I have tested it locally a couple of times and it always passes. I will check on jenkins on Monday, as I think my stage-jenkins job that I normally use has been renamed or removed. I'll ask @pmedapuram about that.

adarsh-ramakrishna-sfdc commented 8 years ago

Changes looks good to me 👍 The second reviewer can review and merge the PR

glang commented 8 years ago

@pmedapuram Hi, would you mind doing the second review for this pull request for me?

pmedapuram commented 8 years ago

👍