search

forcedotcom / ApexUnit

ApexUnit is a powerful continuous integration tool for the Force.com platform
BSD 3-Clause "New" or "Revised" License
71 stars 51 forks source link

password for url is now encoded #45

Closed glang closed 8 years ago

glang commented 8 years ago

A provided password with characters that are not encoded would crash ApexUnit due to the fact that it is appended to a url string. This fix converts the password to an encoded password before appending it to the url string.

glang commented 8 years ago

@pmedapuram @adarsh-ramakrishna-sfdc would you guys mind reviewing and merging this bug fix? Thanks!

adarsh-ramakrishna-sfdc commented 8 years ago

👍 Please make sure to update the version# in pom.xml

pmedapuram commented 8 years ago

@glang is there a way, we can add a test for this bug fix?

And also curious to know the one test that is failing on travis. I guess this is not happening on the local env, correct?

glang commented 8 years ago

@pmedapuram Definitely, I will write one. About the failing test, it indeed does not fail when I run it locally. Do you know if there is a way to check the workspace where Travis is running? Also, is there a way to manually trigger a Travis run?

pmedapuram commented 8 years ago

@glang ltgm 👍

pmedapuram commented 8 years ago

I also see that travis build passed.