forcedotcom / EMP-Connector

A simplified cometd connector for Enterprise Messaging Platform
BSD 3-Clause "New" or "Revised" License
185 stars 243 forks source link

Outdated jetty.HttpClient #35

Open schambers opened 6 years ago

schambers commented 6 years ago

In attempting to consume this project for a project to connect to the salesforce streaming api, it was found that the current org.eclipse.jetty.HttpClient that is used was older (~2 years) than an internal library that was using a newer version.

This older version of HttpClient conflicted with our internal library and failed to acquire any connections to the threadpool used by HttpClient.

While most users of this library wouldn't necessarily see this issue, the problem was resolved by matching versions of our internal library and as a result it may be a good idea to update the version of HttpClient used.

I noticed that this is also tied to the cometd reference so keep in mind that updating HttpClient would required a newer version of cometd which would likely have some conflicts if they're semantically versioned. This library uses 31.0 and cometd is currently on 34.0

Just a heads up/recommendation if anyone else comes across a similar issue.