search

forcedotcom / EMP-Connector

A simplified cometd connector for Enterprise Messaging Platform
BSD 3-Clause "New" or "Revised" License
185 stars 243 forks source link

README contains outdated example #81

Open kschoenSFDC opened 3 years ago

kschoenSFDC commented 3 years ago

In README.md under the section “Build and Execute EMP Connector” we have the following example:

To run EMP Connector using the DevLoginExample class with username and password authentication, use this command. $ java -classpath target/emp-connector-0.0.1-SNAPSHOT-phat.jar com.salesforce.emp.connector.example.DevLoginExample [optional_replay_id]

However, this command will no longer work because DevLoginExample is abstract. The examples should be updated to use DevLoginSynchronousEventProcessingExample or DevLoginAsynchronousEventProcessingExample.

abhinavguptas commented 3 years ago

I am not sure how the official Salesforce documents (https://developer.salesforce.com/docs/atlas.en-us.change_data_capture.meta/change_data_capture/cdc_subscribe_emp_connector.htm) and other one for streaming API are not updated, so is the README here.

The class DevLoginExample is not having a main() method. As pointed by @kschoenSFDC either fixed the DevLoginExample, or please update the README.