Feedback regarding keyboard Shortcuts

[tahabasri]

Originally posted in salesforcedx-vscode-einstein-gpt.

The default provided shortcuts of the extension are overriding some of the most important system shortcuts in VSCode, specially for Mac users. I think this issue can be discussed/resolved as the list of shortcuts is still small and maintainable.

How to reproduce ? MacOS only

• Install Einstein for Developers extension

• Open a repo and connect to a Dev org in which Einstein for Developers is enabled

• Open a random Apex class in VSCode in the open repo

• Put the cursor in the middle of a code line, like below:

• Hit the combo cmd+right in order to go to end of line (default VSCode shortcut)

Expected ?

Cursor should go to end of line

Current behavior

Cursor is stuck on the initial position.

Why ?

The accept command trigger (cmd+right) overrides the System shortcut cursorEnd, the latter is the commonly used within VSCode. User must either change system settings after installing the extension which is not ideal (given that this change applies to Apex files only).

Another useful shortcut that's impacted is the famous cmd+r which is now triggering Einstein: Generate Code instead of reloading VSCode by default.

Suggestions ?

My suggestion is to go with cmd+shift+key as this applies for a small set of File types (Apex for now), the learning curve is not much impacted as the keyset is still small. I'm open for any other type of suggestions. Thanks.

[tahabasri]

As I can't push code to the original repo, here are my suggested changes:

[floralan]

Hi @tahabasri, our team is aware of this issue. We have created an internal work item (W-14194362) to fix it. Thank you for your input!

[d-gunawan]

@tahabasri, we changed our default keybindings for acceptSuggestion and promptForQuery in version 0.23.1 so they should no longer conflict with the system keybindings, more details can be found in our release notes.

The insertCommentForCodeGeneration feature is still behind a feature flag, so it shouldn't cause any keybinding conflict.

[tahabasri]

Great ! Thanks @d-gunawan !