Inconsistent catalog naming

forcedotcom / Salesforce-CDP-jdbc

JDBC driver to connect to Salesforce CDP.

Apache License 2.0

32 stars 29 forks source link

Inconsistent catalog naming #172

Open pajaks opened 3 months ago

pajaks commented 3 months ago

Catalog name from QueryServiceMetadata.getTables is QueryService https://github.com/forcedotcom/Salesforce-CDP-jdbc/blob/43a3d563d9ba4b05b739961886ff8978c7a3d5ec/src/main/java/com/salesforce/cdp/queryservice/core/QueryServiceMetadata.java#L1032 Catalog name from QueryServiceMetadata.getColumns is catalog https://github.com/forcedotcom/Salesforce-CDP-jdbc/blob/43a3d563d9ba4b05b739961886ff8978c7a3d5ec/src/main/java/com/salesforce/cdp/queryservice/core/QueryServiceMetadata.java#L1071

vish689 commented 3 months ago

In datacloud, we don't have a concept of catalog. @pajaks , we are not using the catalog values anywhere, and hence this was given dummy value.

@pajaks is it breaking any of the usecases which you have?

pajaks commented 3 months ago

@pajaks is it breaking any of the usecases which you have?

We had to make some workaround to change value returned by one of the methods to make it consistent. Even if catalog name is dummy we are using it as part of name identifier, so it would be nice to have it consistent.