forcedotcom / SalesforceMobileSDK-Android

Android SDK for Salesforce
Other
341 stars 386 forks source link

Storing language and locale in user account #2525

Closed wmathurin closed 6 months ago

mobilesdk-bot commented 6 months ago
1 Warning
:warning: No Lint Results.

Tests results for SalesforceHybrid

Generated by :no_entry_sign: Danger

mobilesdk-bot commented 6 months ago
1 Error
:no_entry_sign: Tests have failed, see below for more information.
12 Warnings
:warning: libs/SalesforceSDK/src/com/salesforce/androidsdk/accounts/UserAccount.java#L219 - The indentation string here is different from on the previous line (" " vs \t)
:warning: libs/SalesforceSDK/src/com/salesforce/androidsdk/accounts/UserAccount.java#L258 - The indentation string here is different from on the previous line (" " vs \t)
:warning: libs/SalesforceSDK/src/com/salesforce/androidsdk/accounts/UserAccount.java#L739 - The indentation string here is different from on the previous line (" " vs \t)
:warning: libs/SalesforceSDK/src/com/salesforce/androidsdk/accounts/UserAccount.java#L769 - The indentation string here is different from on the previous line (" " vs \t)
:warning: libs/SalesforceSDK/src/com/salesforce/androidsdk/accounts/UserAccount.java#L809 - The indentation string here is different from on the previous line (" " vs \t)
:warning: libs/SalesforceSDK/src/com/salesforce/androidsdk/accounts/UserAccountManager.java#L104 - Do not place Android context classes in static fields (static reference to UserAccountManager which has field context pointing to Context); this is a memory leak
:warning: libs/SalesforceSDK/src/com/salesforce/androidsdk/accounts/UserAccountManager.java#L145 - Consider using apply() instead; commit writes its data to persistent storage immediately, whereas apply will handle it in the background
:warning: libs/SalesforceSDK/src/com/salesforce/androidsdk/accounts/UserAccountManager.java#L212 - The indentation string here is different from on the previous line (" " vs \t)
:warning: libs/SalesforceSDK/src/com/salesforce/androidsdk/accounts/UserAccountManager.java#L562 - The indentation string here is different from on the previous line (" " vs \t)
:warning: libs/SalesforceSDK/src/com/salesforce/androidsdk/accounts/UserAccountManager.java#L578 - The indentation string here is different from on the previous line (" " vs \t)
:warning: libs/SalesforceSDK/src/com/salesforce/androidsdk/auth/AuthenticatorService.java#L56 - Do not place Android context classes in static fields (static reference to Authenticator which has field context pointing to Context); this is a memory leak
:warning: libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/OAuthWebviewHelper.kt#L197 - Using setJavaScriptEnabled can introduce XSS vulnerabilities into your application, review carefully

Tests:

Name Classname Time
testDoesUserAccountExist com.salesforce.androidsdk.accounts.UserAccountManagerTest 0.189
testCreateAccountFromJSON com.salesforce.androidsdk.accounts.UserAccountTest 0.003
testConvertAccountToBundle com.salesforce.androidsdk.accounts.UserAccountTest 0.005

Tests results for SalesforceSDK

Generated by :no_entry_sign: Danger

wmathurin commented 6 months ago

NB: SalesforceHybrid and SalesforceReact tests are all passing locally.

brandonpage commented 6 months ago

NB: SalesforceHybrid and SalesforceReact tests are all passing locally.

I saw that yesterday too. Looks like the gradle process dies sometimes, I tried a rerun.

wmathurin commented 6 months ago

After re-running on CI: