forcedotcom / SalesforceMobileSDK-Android

Android SDK for Salesforce

Other

339 stars 384 forks source link

Make useHybridAuthentication a settable variable. #2549

Closed brandonpage closed 2 months ago

brandonpage commented 2 months ago

I think this just got lost in the SalesforceSDKManager Java to Kotlin conversion.

mobilesdk-bot commented 2 months ago

	1 Error
:no_entry_sign:	Tests have failed, see below for more information.

	3 Warnings
:warning:	libs/SalesforceSDK/src/com/salesforce/androidsdk/app/SalesforceSDKManager.kt#L1441 - Do not place Android context classes in static fields (static reference to `SalesforceSDKManager` which has field `context` pointing to `Context`); this is a memory leak
:warning:	libs/SalesforceSDK/src/com/salesforce/androidsdk/auth/idp/IDPAuthCodeHelper.kt#L72 - Using `setJavaScriptEnabled` can introduce XSS vulnerabilities into your application, review carefully
:warning:	libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/OAuthWebviewHelper.kt#L207 - Using `setJavaScriptEnabled` can introduce XSS vulnerabilities into your application, review carefully

Tests:

Name	Classname	Time
testDecryptDataEncryptedWithNewRSACipherForKeyCreatedBeforeUpgrade	com.salesforce.androidsdk.security.KeyStoreWrapperTest	0.184
testDecryptDataEncryptedWithNewRSACipher	com.salesforce.androidsdk.security.KeyStoreWrapperTest	0.067
testRSAOAEPSHA256EncryptDecrypt	com.salesforce.androidsdk.security.KeyStoreWrapperTest	0.094

Tests results for SalesforceSDK

Generated by :no_entry_sign: Danger