search

forcedotcom / SalesforceMobileSDK-Android

Android SDK for Salesforce
Other
339 stars 384 forks source link

Fix SalesforceSDKManager's instance not being overrideable to subclasse. #2562

Closed brandonpage closed 1 month ago

brandonpage commented 1 month ago

Without this change INSTANCE is actually overridable for Java subclasses, so we didn't notice it being broken for Kotlin consumers.

mobilesdk-bot commented 1 month ago
1 Error
:no_entry_sign: Tests have failed, see below for more information.

Tests:

Name Classname Time
testUserAgentOfHttpAccess com.salesforce.androidsdk.auth.HttpAccessTest 0.554
testShouldShowBackButtonBioAuth com.salesforce.androidsdk.auth.NativeLoginManagerTest 0.237
testBiometricAuthenticationUsername com.salesforce.androidsdk.auth.NativeLoginManagerTest 0.002
testShouldShowBackButton com.salesforce.androidsdk.auth.NativeLoginManagerTest 0.066
testIsEnabled com.salesforce.androidsdk.security.BiometricAuthenticationManagerTest 0.211
testShouldAllowRefresh com.salesforce.androidsdk.security.BiometricAuthenticationManagerTest 0.349
testIsLocked com.salesforce.androidsdk.security.BiometricAuthenticationManagerTest 0.372

Tests results for SalesforceSDK

Generated by :no_entry_sign: Danger