forcedotcom / SalesforceMobileSDK-Android

Android SDK for Salesforce
Other
339 stars 384 forks source link

@W-15061223: [Android] Add additional native login feature: forgot password #2567

Closed JohnsonEricAtSalesforce closed 1 month ago

JohnsonEricAtSalesforce commented 1 month ago

🎸 Ready For Review 🥁

Here MSDK acquires the headless forgot password flow from the Salesforce Identity API.

https://help.salesforce.com/s/articleView?id=sf.remoteaccess_headless_forgot_password_flow.htm&type=5

This follows the style we used for login and password-less login in 12.0. Most of the new code should look quite familiar with the subtle exception of some new utility methods to keep reused logic from becoming redundant.

wmathurin commented 1 month ago

For the API rename, maybe introduce the new one, keep the old one (have it call the new one) and mark the old one as deprecated @Deprecated("Use the ... method - will be removed in 13.0", replaceWith = ReplaceWith("...")). The template can use the new one.

JohnsonEricAtSalesforce commented 1 month ago

For the API rename, maybe introduce the new one, keep the old one (have it call the new one) and mark the old one as deprecated @Deprecated("Use the ... method - will be removed in 13.0", replaceWith = ReplaceWith("...")). The template can use the new one.

I already rolled it back for now, since it was extra credit polish to the developer experience. We can revisit another day.