Closed JohnsonEricAtSalesforce closed 1 month ago
It's worth noting I did intend to include commits from the spike performed by @wmathurin. I rebased his branch on dev
before adding my own commits. Plus, a squash will make this very tidy on dev
when we're done while preserving his history here.
1 Error | |
---|---|
:no_entry_sign: | Tests have failed, see below for more information. |
2 Warnings | |
---|---|
:warning: | libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/LoginActivity.kt#L209 - Using setJavaScriptEnabled can introduce XSS vulnerabilities into your application, review carefully |
:warning: | libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/OAuthWebviewHelper.kt#L215 - Using setJavaScriptEnabled can introduce XSS vulnerabilities into your application, review carefully |
Name | Classname | Time |
---|---|---|
testRestClientUnauthenticatedlientInfoAsync | com.salesforce.androidsdk.rest.RestClientTest | 10.236 |
Generated by :no_entry_sign: Danger
Hold merging this to dev
and the 12.1.0
codebase until we confirm the iOS version will also make it in time for the release.
Attention: Patch coverage is 16.98113%
with 44 lines
in your changes missing coverage. Please review.
Project coverage is 57.10%. Comparing base (
301e0f4
) to head (6f0974e
). Report is 72 commits behind head on dev.
1 Warning | |
---|---|
:warning: | No Lint Results. |
Generated by :no_entry_sign: Danger
1 Error | |
---|---|
:no_entry_sign: | Tests have failed, see below for more information. |
Name | Classname | Time |
---|---|---|
test[testCleanResyncGhosts] | com.salesforce.androidsdk.reactnative.ReactMobileSyncTest | 131.635 |
Generated by :no_entry_sign: Danger
1 Warning | |
---|---|
:warning: | No Lint Results. |
Generated by :no_entry_sign: Danger
🎸 Ready For Review! 🥁
This adds support for log in via log in QR codes generated with the UI Bridge API to MSDK. This completes a very detailed spike previously completed by @wmathurin and directly inherits from that codebase.
Before reviewing, I highly recommend reading this document and references in detail: 👉🏻 https://salesforce.quip.com/JXmvAwirhR3V
There's actually very little if any logic change from the spike code. What I did try to apply was my novice's eye to the topic so we can name and document the code such that it'll be a bit more approachable for those uninitiated to the UI Bridge API, how that is delivered via the QR code and the many touch points that has in MSDK's log in logic. I did the same in the companion pull request that introduces commented out content to our template guiding a developer through enabling this in a new app.
The companion template update is in https://github.com/forcedotcom/SalesforceMobileSDK-Templates/pull/417