forcedotcom / SalesforceMobileSDK-Android

Android SDK for Salesforce
Other
341 stars 388 forks source link

W-16498231: [MSDK Android] Native User Registration No Longer Sets User's Initial Password #2602

Closed JohnsonEricAtSalesforce closed 3 months ago

JohnsonEricAtSalesforce commented 3 months ago

🎸 Ready For Review! 🥁

This simple and low risk bug fix simply moves the password parameter in start user registration to where the Salesforce Identity API expects (now) according to the documentation.

I've tested this using the AndroidNativeLoginTemplate and ensured the user's new password works as expected after registration.

mobilesdk-bot commented 3 months ago
1 Error
:no_entry_sign: Tests have failed, see below for more information.
1 Warning
:warning: No Lint Results.

Tests:

Name Classname Time
test[testCleanResyncGhosts] com.salesforce.androidsdk.reactnative.ReactMobileSyncTest 132.6

Tests results for SalesforceReact

Generated by :no_entry_sign: Danger

mobilesdk-bot commented 3 months ago
1 Error
:no_entry_sign: Tests have failed, see below for more information.

Tests:

Name Classname Time
testCleanGhostsOneObjectType com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 1.375
testSyncDownFetchingOneObjectType com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 1.98
testSyncDownFetchingTwoObjectTypes com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 4.311
testIdsToSkip com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 1.783
testStartFetchWithMaxTimeStamp com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 3.657
testCleanGhostsTwoObjectTypes com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 1.795
testSyncDownFetchingOneObjectTypeWithMultipleRetrieveCalls com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 1.949
testStartFetchNoMaxTimeStamp com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 2.687
testSyncDownFetchingTwoObjectTypesWithMultipleRetrieveCalls com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 3.869

Tests results for MobileSync

Generated by :no_entry_sign: Danger