forcedotcom / SalesforceMobileSDK-Android

Android SDK for Salesforce
Other
341 stars 388 forks source link

Fix push deregister error. #2615

Closed brandonpage closed 1 month ago

brandonpage commented 2 months ago

In #2545 I made a change to delay push deregister until the device had network connection so that the operation would succeed (eventually) even if the user chose to logout while offline. At the time of testing this worked correctly in all cases but since a change has been made that causes an error on deregister (likely the recent bugfix #2607, which retained the tokens after logout). The error doesn't actually cause the unregister operation to fail and is invisible to the end user, but an internal team ran into issues with automated testing because of it.

mobilesdk-bot commented 2 months ago
1 Warning
:warning: No Lint Results.

Tests results for SalesforceHybrid

Generated by :no_entry_sign: Danger

mobilesdk-bot commented 2 months ago
1 Error
:no_entry_sign: Tests have failed, see below for more information.

Tests:

Name Classname Time
testCleanGhostsOneObjectType com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 1.368
testSyncDownFetchingOneObjectType com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 2.084
testSyncDownFetchingTwoObjectTypes com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 3.846
testIdsToSkip com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 2.131
testStartFetchWithMaxTimeStamp com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 3.826
testCleanGhostsTwoObjectTypes com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 1.979
testSyncDownFetchingOneObjectTypeWithMultipleRetrieveCalls com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 2.393
testStartFetchNoMaxTimeStamp com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 2.377
testSyncDownFetchingTwoObjectTypesWithMultipleRetrieveCalls com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 4.669

Tests results for MobileSync

Generated by :no_entry_sign: Danger