search

forcedotcom / SalesforceMobileSDK-ReactNative

BSD 3-Clause "New" or "Revised" License
48 stars 55 forks source link

This library does not conform to RN standards #325

Open billnbell opened 1 year ago

billnbell commented 1 year ago

There are several real issues with this library.

  1. First the RN standard is to create a package that loads in Android and IOS - not doing it in a CLI command
  2. The RN 70.* new architecture and removing the RN Bridging mode needs to happen

Deploying to NPM so that we can yarn add react-native-force and then yarn ios / yarn android should be ALL you ever need.

Can we get some help forking this and fixing it to conform to how everyone else does it?

wmathurin commented 1 year ago

We have it in our backlog to revisit how we do our react native templates and bridging, but no time set yet for getting to that work.

JFoxUK commented 1 year ago

This is an absolute must and is one of the reasons why we stay clear from using the Salesforce SDK most of the time.

billnbell commented 1 year ago

Yeah if you just look at this repo that is a good example of how to do it.

I converted this to work with RN Bridging and this compiles without doing any injection into Xcode or Android Studio files.

https://github.com/billnbell/react-native-sunshine-conversations

  1. Create a pod spec react-native-smooch.podspec
  2. Create build.gradle with dependencies https://github.com/billnbell/react-native-sunshine-conversations/blob/master/android/build.gradle
billnbell commented 1 year ago

Or just copy your competitor's setup. https://github.com/FormidableLabs/react-native-app-auth

JFoxUK commented 1 year ago

@wmathurin @bbirman is this on the roadmap?

hmkcfs commented 3 weeks ago

@wmathurin @bbirman , React Native team officially suggested to use frameworks like exp. When will you guys support Expo for Salesforce mobile SDK

https://reactnative.dev/blog/2024/06/25/use-a-framework-to-build-react-native-apps