search

forcedotcom / SalesforceMobileSDK-ReactNative

BSD 3-Clause "New" or "Revised" License
49 stars 55 forks source link

@W-13557285: [Android] Upgrade to Gradle 8.x and AGP 8.x Via RN 0.72.x #345

Closed JohnsonEricAtSalesforce closed 9 months ago

JohnsonEricAtSalesforce commented 10 months ago

🎸 Ready For Final Review 🥁

Be aware this pull request is one of four related to the React Native 0.72.7, Gradle 8.2 and Android Gradle Plugin 8.2.0 upgrades. 👉🏻 https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/2492 👉🏻 https://github.com/forcedotcom/SalesforceMobileSDK-CordovaPlugin/pull/631 👉🏻 https://github.com/forcedotcom/SalesforceMobileSDK-ReactNative/pull/345 👉🏻 https://github.com/forcedotcom/SalesforceMobileSDK-Templates/pull/387

This prepares SalesforceMobileSDK-ReactNative for supporting React Native 0.72.7, Gradle 8.2, Android Gradle Plugin 8.2.0 and Android 34 in the other three repositories listed above. Overall, the changes here are relatively small though the platform update has significant impacts to downstream projects.

I tested this primarily by using forcereact to generate every React Native template I could conceive of. Everything compiled and ran OK for both Android and iOS.

wmathurin commented 10 months ago

Also could you subject of the PR reflect the fact it has a RN upgrade?