Add Kotlin Dependency and update Gradle

forcedotcom / SalesforceMobileSDK-Templates

BSD 3-Clause "New" or "Revised" License

52 stars 56 forks source link

Add Kotlin Dependency and update Gradle #350

Closed brandonpage closed 1 year ago

brandonpage commented 1 year ago

TODO:

[x] Update Kotlin for hybrid apps - Done in CordovaPlugin PR
[x] Fix MobileSyncExplorerReactNative compilation (this may just be my environment) - JVM needed more memory.

brandonpage commented 1 year ago

LGTM What needs to be done for the generated hybrid apps?

That is a great question. cdv-gradle-config.json specifies Kotlin 1.5.21 but I am not sure where it is coming from. It doesn't seem like they should compile, but they do. Comcast is doing work in my neighborhood so I mostly just wanted to get this PR out before the internet goes out. I will update the PR when I get that fixed (probably in CordovaPlugin?).

wmathurin commented 1 year ago

The plugin can override values that come from the cordova json files - we do that already here, it's just a matter of figuring out the property name.