forcedotcom / SalesforceMobileSDK-Templates

BSD 3-Clause "New" or "Revised" License
52 stars 56 forks source link

@W-13557285: [Android] Upgrade to Gradle 8.x and AGP 8.x Via RN 0.72.x #387

Closed JohnsonEricAtSalesforce closed 11 months ago

JohnsonEricAtSalesforce commented 12 months ago

šŸŽø Ready For Final Review šŸ„

Be aware this pull request is one of four related to the React Native 0.72.7, Gradle 8.2 and Android Gradle Plugin 8.2.0 upgrades. šŸ‘‰šŸ» https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/2492 šŸ‘‰šŸ» https://github.com/forcedotcom/SalesforceMobileSDK-CordovaPlugin/pull/631 šŸ‘‰šŸ» https://github.com/forcedotcom/SalesforceMobileSDK-ReactNative/pull/345 šŸ‘‰šŸ» https://github.com/forcedotcom/SalesforceMobileSDK-Templates/pull/387

The bulk of the upgrade effort resides here in the templates. There are impacts for every template except the stand-alone iOS templates. The React Native templates also received the heaviest changes, which was according to the official React Native Upgrade Helper tool.

For testing, I was able to use the package tools to build and run as many permutations of the affected templates as I could. Everything seemed to run as expected.

The difference report is quite long, but I was able to read through it line-for-line and make a few cleanup commits. Let me know if anything looks amiss. Thanks for your patience with this bigger than usual set of interrelated upgrades.