search

forcedotcom / SalesforceMobileSDK-Templates

BSD 3-Clause "New" or "Revised" License
52 stars 56 forks source link

@W-15611884: [MSDK Android] Android Native Login Template Cannot Be Created Due To Invalid Package Names #407

Closed JohnsonEricAtSalesforce closed 6 months ago

JohnsonEricAtSalesforce commented 6 months ago

🎸 Ready For Review 🥁

This is an easy one. The package names in Kotlin for this template changed after it was created and this catches the template script up with that.

brandonpage commented 6 months ago

Where are you seeing a problem with this? androidnativelogintemplate seems correct to me.

wmathurin commented 6 months ago

That line should take care of it: https://github.com/forcedotcom/SalesforceMobileSDK-Templates/blob/dev/AndroidNativeLoginTemplate/template.js#L61

brandonpage commented 6 months ago

I believe this is the correct way to fix the issue: https://github.com/forcedotcom/SalesforceMobileSDK-Templates/pull/408

brandonpage commented 6 months ago

Fixed by https://github.com/forcedotcom/SalesforceMobileSDK-Templates/pull/408