search

forcedotcom / SalesforceMobileSDK-Templates

BSD 3-Clause "New" or "Revised" License
52 stars 56 forks source link

W-16171426: [Android] Update Native Login Sample App to include QR Code Login Flow #417

Closed JohnsonEricAtSalesforce closed 1 month ago

JohnsonEricAtSalesforce commented 3 months ago

🎸 Ready For Review! 🥁

This is a companion to https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/2594. Do read that in detail before beginning here.

This adds commented code to the Android Native Kotlin template detailing how to enable login via a UI Bridge API generated log in QR code. This is web login specific, so when I chatted with @wmathurin regarding which template this should live in, we easily ruled out the newer Native Login Template. It's also an optional feature that builds logically on the Android Native Kotlin Template, so having it commented out in this context seems to make sense without adding too much clutter.

I used a consistent comment phrase throughout to make it easier to document how to find all the touch points in the template. With those commented out, the template behaves as it does on dev. For anyone wanting to test, just checkout one earlier commit to test with a fully working configuration.

JohnsonEricAtSalesforce commented 3 months ago

It's worth noting I did intend to include commits from the spike performed by @wmathurin. I rebased his branch on dev before adding my own commits. Plus, a squash will make this very tidy on dev when we're done while preserving his history here.

JohnsonEricAtSalesforce commented 3 months ago

Hold merging this to dev and the 12.1.0 codebase until we confirm the iOS version will also make it in time for the release.