search

forcedotcom / analyticsdx-vscode

Salesforce Analytics Extensions for Visual Studio Code
BSD 3-Clause "New" or "Revised" License
11 stars 2 forks source link

Add new number variable properties to template editing #158

Closed aarondailsf2023 closed 1 year ago

aarondailsf2023 commented 1 year ago

What does this PR do?

Adds support for the new format and scale properties on the variableType object in the variables json.

What issues does this PR fix or reference?

@W-13859170@

aarondailsf2023 commented 1 year ago

variableSchema.test.ts also has a test for the various code-completions for the various variable types coming from the schema (to make sure we don't break things) -- look for the NumberType entry in has correct code completions for variableType in there, to make sure that format and scale show up for number types. And, probably need a test in there for the enum values for format.

I made a change to test the code completions, but not for the specific format enum values yet. Will do that next.

aarondailsf2023 commented 1 year ago

OK @smithgp I added an integration test for the format completions.