Adding ConnectorType to variable type enums

forcedotcom / analyticsdx-vscode

Salesforce Analytics Extensions for Visual Studio Code

BSD 3-Clause "New" or "Revised" License

11 stars 2 forks source link

Adding ConnectorType to variable type enums #26

Closed karihotchkiss closed 4 years ago

karihotchkiss commented 4 years ago

This PR adds the ConnectorType enum to the variableType schema, along with connectorType to variable type

This fixes: https://github.com/forcedotcom/analyticsdx-vscode/projects/1#card-28475433

smithgp commented 4 years ago

@karihotchkiss Also, for a vscode-integration test, it would be cool at add ConnectorType to the list of code-completions to verify for the variableType.type in the editor -- check out extensions/analyticsdx-vscode-templates/test/vscode-integration/templateEditing.test.ts around line 763.

karihotchkiss commented 4 years ago

Cool - thanks @smithgp , I'll add both tests now.