forcedotcom / analyticsdx-vscode

Salesforce Analytics Extensions for Visual Studio Code
BSD 3-Clause "New" or "Revised" License
11 stars 2 forks source link

Figure out why linux tests fail in github actions #36

Closed smithgp closed 4 years ago

smithgp commented 4 years ago

Linux vscode-integration tests started failing in github actions: https://github.com/forcedotcom/analyticsdx-vscode/runs/406150729

Basically, runTest() from vscode-test gets a null exitCode, which possibly means there was a signal that killed the process or it core dumped, or something else. Nothing related in the repo seemed to have changed, and both the bad runs and the last good run were downloading vscode 1.41.1. Doesn't appear related to the --no-sandbox issues w/ electron on linux, since I both manually passed that in and updated to vscode 1.3.0 (which passes it in) to no effect.

I did some experimenting in #35, but couldn't fix it. So, I turned off requiring the linux build for PRs for now, but we need to figure it out.

Possibly the same as or related to microsoft/vscode#89147. Could be that github changed something in the ubuntu-latest VMs it creates.