forcedotcom / analyticsdx-vscode

Salesforce Analytics Extensions for Visual Studio Code
BSD 3-Clause "New" or "Revised" License
11 stars 2 forks source link

Use vscode.env.openExternal() in VSO #84

Closed smithgp closed 4 years ago

smithgp commented 4 years ago

for opening analytics studio while in Visual Studio Online (or other web-based VSCode envs, like theia).

I can't seem to get Studio urls that use a # to work when going through sfdx -> Uri.parse() -> openExternal() -> frontdoor.jsp -> retURL, something in there seems to double-encode the query params in a way which the server then doesn't double-decode correctly, and it gets a 404 from the server since the # in the url ends up as a literal %23 instead of the original #. Since the Studio UI is going to move to /-based url navigation in a near future release (where /'s do seem to work fine), we can update things to always use openExternal() in the future, and for now just not show our #-url-based in VOS.