Pulling source from scratch org recreates custom layouts in default directory

ChloeCoon commented 2 years ago

Summary

Anytime we run sfdx force:source:pull, some of our Layouts we have in our managed package get recreated into another directory (the default directory we have specified in sfdx-project.json). If we remove them from the default directory and try to push to the same scratch org, we get an error:

 An unexpected error occurred. Please include this ErrorId if you contact support: 486806388-58479 (1736601553)

The Layouts that we have this problem with have version numbers in their names like "AssignmentHistory__c-v1%2E34 Assignment History Layout.layout-meta.xml".

Steps To Reproduce:

Add a Layout and save it in the non-default directory (ours are specifically saved in src/gradient-works/main/routing/layouts)
Run sfdx force:source:pull

Expected result

I would expect nothing to be pulled down and no Layouts to be created

Actual result

The Layout is recreated in the default directory

System Information

❯ sfdx version --verbose --json
{
  "cliVersion": "sfdx-cli/7.164.2",
  "architecture": "darwin-x64",
  "nodeVersion": "node-v16.17.0",
  "pluginVersions": [
    "@oclif/plugin-autocomplete 1.3.0 (core)",
    "@oclif/plugin-commands 2.2.0 (core)",
    "@oclif/plugin-help 5.1.12 (core)",
    "@oclif/plugin-not-found 2.3.1 (core)",
    "@oclif/plugin-plugins 2.1.0 (core)",
    "@oclif/plugin-update 3.0.0 (core)",
    "@oclif/plugin-version 1.1.1 (core)",
    "@oclif/plugin-warn-if-update-available 2.0.4 (core)",
    "@oclif/plugin-which 2.1.0 (core)",
    "alias 2.1.0 (core)",
    "apex 1.1.0 (core)",
    "auth 2.2.3 (core)",
    "community 2.0.0 (core)",
    "config 1.4.17 (core)",
    "custom-metadata 2.0.0 (core)",
    "data 2.1.2 (core)",
    "generator 2.0.2 (core)",
    "info 2.0.1 (core)",
    "limits 2.0.1 (core)",
    "org 2.2.0 (core)",
    "schema 2.1.1 (core)",
    "signups 1.2.0 (core)",
    "source 2.0.12 (core)",
    "telemetry 2.0.0 (core)",
    "templates 55.1.0 (core)",
    "trust 2.0.3 (core)",
    "user 2.1.0 (core)",
    "@salesforce/sfdx-plugin-lwc-test 1.0.0 (core)",
    "salesforce-alm 54.8.1 (core)"
  ],
  "osVersion": "Darwin 21.6.0"
}

Additional information

github-actions[bot] commented 2 years ago

Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support.

iowillhoit commented 2 years ago

Thanks for the issue @ChloeCoon. I tried reproducing this but was unable to. I've got a few questions:

Has this just started happening recently? Do older versions of the CLI work as expected?
Does this only happen when you are using Layouts with "version numbers in their names"?
Could please try creating a demo repo using https://github.com/trailheadapps/dreamhouse-lwc with Layouts included that will help me reproduce this?

Thanks!

ChloeCoon commented 2 years ago

@iowillhoit thanks for reaching out, here is the requested info:

We have seen this issue since version 7.144 iirc. At the very least, it has been happening for me for the last several versions, it's not new to the latest release.
We only see this happen for our layouts that have version numbers in the name. I've included a screenshot of the layouts we see in the source pull output and a screenshot of all of the layouts that live in the same directory as those layouts. As you can see, there are some layouts without version numbers that do not get recreated on source pull.
Here you go: https://github.com/ChloeCoon/dreamhouse-lwc

Once you have that repo cloned, you should be able to create a scratch org, run source push and then immediately run source pull to repro the issue we're seeing. I've included what it looks like when I do these steps.

dreamhouse-lwc on  main is 📦 v1.0.0 via  v17.7.1 on ☁️  (us-east-2) 
❯ git status                                                                             
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

dreamhouse-lwc on  main is 📦 v1.0.0 via  v17.7.1 on ☁️  (us-east-2) 
❯ sfdx force:org:create -f config/project-scratch-def.json -a dreamhouse-lwc-test-2 -v DevHub
Successfully created scratch org: 00D55000000UPKTEA4, username: test-dpfoed7xm8cc@example.com.

dreamhouse-lwc on  main is 📦 v1.0.0 via  v17.7.1 on ☁️  (us-east-2) took 25s 
❯ sfdx force:source:push -u dreamhouse-lwc-test-2                                            
*** Pushing with SOAP API v55.0 ***
DEPLOY PROGRESS | ████████████████████████████████████████ | 89/89 Components
Updating source tracking... done

=== Pushed Source

 STATE   FULL NAME                           TYPE                     PROJECT PATH                                                                                                 
 ─────── ─────────────────────────────────── ──────────────────────── ──────────────────────────────────────────────────────────────────────────────────────────────────────────── 
 Created GeocodingService                    ApexClass                src/force-app/main/default/classes/GeocodingService.cls                                                      
 Created GeocodingService                    ApexClass                src/force-app/main/default/classes/GeocodingService.cls-meta.xml                                             
 Created GeocodingServiceTest                ApexClass                src/force-app/main/default/classes/GeocodingServiceTest.cls                                                  
 Created GeocodingServiceTest                ApexClass                src/force-app/main/default/classes/GeocodingServiceTest.cls-meta.xml                                         
 Created PagedResult                         ApexClass                src/force-app/main/default/classes/PagedResult.cls                                                           
 Created PagedResult                         ApexClass                src/force-app/main/default/classes/PagedResult.cls-meta.xml                                                  
 Created PropertyController                  ApexClass                src/force-app/main/default/classes/PropertyController.cls                                                    
 Created PropertyController                  ApexClass                src/force-app/main/default/classes/PropertyController.cls-meta.xml                                           
 Created SampleDataController                ApexClass                src/force-app/main/default/classes/SampleDataController.cls                                                  
 Created SampleDataController                ApexClass                src/force-app/main/default/classes/SampleDataController.cls-meta.xml                                         
 Created TestPropertyController              ApexClass                src/force-app/main/default/classes/TestPropertyController.cls                                                
 Created TestPropertyController              ApexClass                src/force-app/main/default/classes/TestPropertyController.cls-meta.xml                                       
 Created TestSampleDataController            ApexClass                src/force-app/main/default/classes/TestSampleDataController.cls                                              
 Created TestSampleDataController            ApexClass                src/force-app/main/default/classes/TestSampleDataController.cls-meta.xml                                     
 Created auraPropertyListMap                 AuraDefinitionBundle     src/force-app/main/default/aura/auraPropertyListMap/auraPropertyListMap.cmp                                  
 Created auraPropertyListMap                 AuraDefinitionBundle     src/force-app/main/default/aura/auraPropertyListMap/auraPropertyListMap.cmp-meta.xml                         
 Created auraPropertyListMap                 AuraDefinitionBundle     src/force-app/main/default/aura/auraPropertyListMap/auraPropertyListMap.css                                  
 Created auraPropertyListMap                 AuraDefinitionBundle     src/force-app/main/default/aura/auraPropertyListMap/auraPropertyListMap.design                               
 Created auraPropertyListMap                 AuraDefinitionBundle     src/force-app/main/default/aura/auraPropertyListMap/auraPropertyListMapController.js                         
 Created auraPropertyListMap                 AuraDefinitionBundle     src/force-app/main/default/aura/auraPropertyListMap/auraPropertyListMapHelper.js                             
 Created auraPropertyListMap                 AuraDefinitionBundle     src/force-app/main/default/aura/auraPropertyListMap/auraPropertyListMapRenderer.js                           
 Created pageTemplate_2_7_3                  AuraDefinitionBundle     src/force-app/main/default/aura/pageTemplate_2_7_3/pageTemplate_2_7_3.cmp                                    
 Created pageTemplate_2_7_3                  AuraDefinitionBundle     src/force-app/main/default/aura/pageTemplate_2_7_3/pageTemplate_2_7_3.cmp-meta.xml                           
 Created pageTemplate_2_7_3                  AuraDefinitionBundle     src/force-app/main/default/aura/pageTemplate_2_7_3/pageTemplate_2_7_3.design                                 
 Created pageTemplate_2_7_3                  AuraDefinitionBundle     src/force-app/main/default/aura/pageTemplate_2_7_3/pageTemplate_2_7_3.svg                                    
 Created Broker__c.Broker_Compact            CompactLayout            src/force-app/main/default/objects/Broker__c/compactLayouts/Broker_Compact.compactLayout-meta.xml            
 Created Broker__c.Broker_Compact            CompactLayout            src/force-app/main/default/objects/Broker__c/compactLayouts/Broker_Compact.compactLayout-meta.xml            
 Created Property__c.Property_Compact_Layout CompactLayout            src/force-app/main/default/objects/Property__c/compactLayouts/Property_Compact_Layout.compactLayout-meta.xml 
 Created Property__c.Property_Compact_Layout CompactLayout            src/force-app/main/default/objects/Property__c/compactLayouts/Property_Compact_Layout.compactLayout-meta.xml 
 Created dreamhouselogosquare                ContentAsset             src/force-app/main/default/contentassets/dreamhouselogosquare.asset                                          
 Created dreamhouselogosquare                ContentAsset             src/force-app/main/default/contentassets/dreamhouselogosquare.asset-meta.xml                                 
 Created Dreamhouse                          CustomApplication        src/force-app/main/default/applications/Dreamhouse.app-meta.xml                                              
 Created Broker__c.Broker_Id__c              CustomField              src/force-app/main/default/objects/Broker__c/fields/Broker_Id__c.field-meta.xml                              
 Created Broker__c.Broker_Id__c              CustomField              src/force-app/main/default/objects/Broker__c/fields/Broker_Id__c.field-meta.xml                              
 Created Broker__c.Email__c                  CustomField              src/force-app/main/default/objects/Broker__c/fields/Email__c.field-meta.xml                                  
 Created Broker__c.Email__c                  CustomField              src/force-app/main/default/objects/Broker__c/fields/Email__c.field-meta.xml                                  
 Created Broker__c.Mobile_Phone__c           CustomField              src/force-app/main/default/objects/Broker__c/fields/Mobile_Phone__c.field-meta.xml                           
 Created Broker__c.Mobile_Phone__c           CustomField              src/force-app/main/default/objects/Broker__c/fields/Mobile_Phone__c.field-meta.xml                           
 Created Broker__c.Phone__c                  CustomField              src/force-app/main/default/objects/Broker__c/fields/Phone__c.field-meta.xml                                  
 Created Broker__c.Phone__c                  CustomField              src/force-app/main/default/objects/Broker__c/fields/Phone__c.field-meta.xml                                  
 Created Broker__c.Picture_IMG__c            CustomField              src/force-app/main/default/objects/Broker__c/fields/Picture_IMG__c.field-meta.xml                            
 Created Broker__c.Picture_IMG__c            CustomField              src/force-app/main/default/objects/Broker__c/fields/Picture_IMG__c.field-meta.xml                            
 Created Broker__c.Picture__c                CustomField              src/force-app/main/default/objects/Broker__c/fields/Picture__c.field-meta.xml                                
 Created Broker__c.Picture__c                CustomField              src/force-app/main/default/objects/Broker__c/fields/Picture__c.field-meta.xml                                
 Created Broker__c.Title__c                  CustomField              src/force-app/main/default/objects/Broker__c/fields/Title__c.field-meta.xml                                  
 Created Broker__c.Title__c                  CustomField              src/force-app/main/default/objects/Broker__c/fields/Title__c.field-meta.xml                                  
 Created Property__c.Address__c              CustomField              src/force-app/main/default/objects/Property__c/fields/Address__c.field-meta.xml                              
 Created Property__c.Address__c              CustomField              src/force-app/main/default/objects/Property__c/fields/Address__c.field-meta.xml                              
 Created Property__c.Assessed_Value__c       CustomField              src/force-app/main/default/objects/Property__c/fields/Assessed_Value__c.field-meta.xml                       
 Created Property__c.Assessed_Value__c       CustomField              src/force-app/main/default/objects/Property__c/fields/Assessed_Value__c.field-meta.xml                       
 Created Property__c.Baths__c                CustomField              src/force-app/main/default/objects/Property__c/fields/Baths__c.field-meta.xml                                
 Created Property__c.Baths__c                CustomField              src/force-app/main/default/objects/Property__c/fields/Baths__c.field-meta.xml                                
 Created Property__c.Beds__c                 CustomField              src/force-app/main/default/objects/Property__c/fields/Beds__c.field-meta.xml                                 
 Created Property__c.Beds__c                 CustomField              src/force-app/main/default/objects/Property__c/fields/Beds__c.field-meta.xml                                 
 Created Property__c.Broker__c               CustomField              src/force-app/main/default/objects/Property__c/fields/Broker__c.field-meta.xml                               
 Created Property__c.Broker__c               CustomField              src/force-app/main/default/objects/Property__c/fields/Broker__c.field-meta.xml                               
 Created Property__c.City__c                 CustomField              src/force-app/main/default/objects/Property__c/fields/City__c.field-meta.xml                                 
 Created Property__c.City__c                 CustomField              src/force-app/main/default/objects/Property__c/fields/City__c.field-meta.xml                                 
 Created Property__c.Date_Agreement__c       CustomField              src/force-app/main/default/objects/Property__c/fields/Date_Agreement__c.field-meta.xml                       
 Created Property__c.Date_Agreement__c       CustomField              src/force-app/main/default/objects/Property__c/fields/Date_Agreement__c.field-meta.xml                       
 Created Property__c.Date_Closed__c          CustomField              src/force-app/main/default/objects/Property__c/fields/Date_Closed__c.field-meta.xml                          
 Created Property__c.Date_Closed__c          CustomField              src/force-app/main/default/objects/Property__c/fields/Date_Closed__c.field-meta.xml                          
 Created Property__c.Date_Contracted__c      CustomField              src/force-app/main/default/objects/Property__c/fields/Date_Contracted__c.field-meta.xml                      
 Created Property__c.Date_Contracted__c      CustomField              src/force-app/main/default/objects/Property__c/fields/Date_Contracted__c.field-meta.xml                      
 Created Property__c.Date_Listed__c          CustomField              src/force-app/main/default/objects/Property__c/fields/Date_Listed__c.field-meta.xml                          
 Created Property__c.Date_Listed__c          CustomField              src/force-app/main/default/objects/Property__c/fields/Date_Listed__c.field-meta.xml                          
 Created Property__c.Date_Pre_Market__c      CustomField              src/force-app/main/default/objects/Property__c/fields/Date_Pre_Market__c.field-meta.xml                      
 Created Property__c.Date_Pre_Market__c      CustomField              src/force-app/main/default/objects/Property__c/fields/Date_Pre_Market__c.field-meta.xml                      
 Created Property__c.Days_On_Market__c       CustomField              src/force-app/main/default/objects/Property__c/fields/Days_On_Market__c.field-meta.xml                       
 Created Property__c.Days_On_Market__c       CustomField              src/force-app/main/default/objects/Property__c/fields/Days_On_Market__c.field-meta.xml                       
 Created Property__c.Description__c          CustomField              src/force-app/main/default/objects/Property__c/fields/Description__c.field-meta.xml                          
 Created Property__c.Description__c          CustomField              src/force-app/main/default/objects/Property__c/fields/Description__c.field-meta.xml                          
 Created Property__c.Location__c             CustomField              src/force-app/main/default/objects/Property__c/fields/Location__c.field-meta.xml                             
 Created Property__c.Location__c             CustomField              src/force-app/main/default/objects/Property__c/fields/Location__c.field-meta.xml                             
 Created Property__c.Picture_IMG__c          CustomField              src/force-app/main/default/objects/Property__c/fields/Picture_IMG__c.field-meta.xml                          
 Created Property__c.Picture_IMG__c          CustomField              src/force-app/main/default/objects/Property__c/fields/Picture_IMG__c.field-meta.xml                          
 Created Property__c.Picture__c              CustomField              src/force-app/main/default/objects/Property__c/fields/Picture__c.field-meta.xml                              
 Created Property__c.Picture__c              CustomField              src/force-app/main/default/objects/Property__c/fields/Picture__c.field-meta.xml                              
 Created Property__c.Price_Sold__c           CustomField              src/force-app/main/default/objects/Property__c/fields/Price_Sold__c.field-meta.xml                           
 Created Property__c.Price_Sold__c           CustomField              src/force-app/main/default/objects/Property__c/fields/Price_Sold__c.field-meta.xml                           
 Created Property__c.Price__c                CustomField              src/force-app/main/default/objects/Property__c/fields/Price__c.field-meta.xml                                
 Created Property__c.Price__c                CustomField              src/force-app/main/default/objects/Property__c/fields/Price__c.field-meta.xml                                
 Created Property__c.Record_Link__c          CustomField              src/force-app/main/default/objects/Property__c/fields/Record_Link__c.field-meta.xml                          
 Created Property__c.Record_Link__c          CustomField              src/force-app/main/default/objects/Property__c/fields/Record_Link__c.field-meta.xml                          
 Created Property__c.State__c                CustomField              src/force-app/main/default/objects/Property__c/fields/State__c.field-meta.xml                                
 Created Property__c.State__c                CustomField              src/force-app/main/default/objects/Property__c/fields/State__c.field-meta.xml                                
 Created Property__c.Status__c               CustomField              src/force-app/main/default/objects/Property__c/fields/Status__c.field-meta.xml                               
 Created Property__c.Status__c               CustomField              src/force-app/main/default/objects/Property__c/fields/Status__c.field-meta.xml                               
 Created Property__c.Tags__c                 CustomField              src/force-app/main/default/objects/Property__c/fields/Tags__c.field-meta.xml                                 
 Created Property__c.Tags__c                 CustomField              src/force-app/main/default/objects/Property__c/fields/Tags__c.field-meta.xml                                 
 Created Property__c.Thumbnail_IMG__c        CustomField              src/force-app/main/default/objects/Property__c/fields/Thumbnail_IMG__c.field-meta.xml                        
 Created Property__c.Thumbnail_IMG__c        CustomField              src/force-app/main/default/objects/Property__c/fields/Thumbnail_IMG__c.field-meta.xml                        
 Created Property__c.Thumbnail__c            CustomField              src/force-app/main/default/objects/Property__c/fields/Thumbnail__c.field-meta.xml                            
 Created Property__c.Thumbnail__c            CustomField              src/force-app/main/default/objects/Property__c/fields/Thumbnail__c.field-meta.xml                            
 Created Property__c.Zip__c                  CustomField              src/force-app/main/default/objects/Property__c/fields/Zip__c.field-meta.xml                                  
 Created Property__c.Zip__c                  CustomField              src/force-app/main/default/objects/Property__c/fields/Zip__c.field-meta.xml                                  
 Created Broker__c                           CustomObject             src/force-app/main/default/objects/Broker__c/Broker__c.object-meta.xml                                       
 Created Property__c                         CustomObject             src/force-app/main/default/objects/Property__c/Property__c.object-meta.xml                                   
 Created Broker__c                           CustomTab                src/force-app/main/default/tabs/Broker__c.tab-meta.xml                                                       
 Created Property_Explorer                   CustomTab                src/force-app/main/default/tabs/Property_Explorer.tab-meta.xml                                               
 Created Property_Finder                     CustomTab                src/force-app/main/default/tabs/Property_Finder.tab-meta.xml                                                 
 Created Property__c                         CustomTab                src/force-app/main/default/tabs/Property__c.tab-meta.xml                                                     
 Created Settings                            CustomTab                src/force-app/main/default/tabs/Settings.tab-meta.xml                                                        
 Created Broker_Record_Page                  FlexiPage                src/force-app/main/default/flexipages/Broker_Record_Page.flexipage-meta.xml                                  
 Created Property_Explorer                   FlexiPage                src/force-app/main/default/flexipages/Property_Explorer.flexipage-meta.xml                                   
 Created Property_Finder                     FlexiPage                src/force-app/main/default/flexipages/Property_Finder.flexipage-meta.xml                                     
 Created Property_Record_Page                FlexiPage                src/force-app/main/default/flexipages/Property_Record_Page.flexipage-meta.xml                                
 Created Settings                            FlexiPage                src/force-app/main/default/flexipages/Settings.flexipage-meta.xml                                            
 Created Create_property                     Flow                     src/force-app/main/default/flows/Create_property.flow-meta.xml                                               
 Changed Broker__c-Broker Layout             Layout                   src/force-app/main/default/layouts/Broker__c-Broker Layout.layout-meta.xml                                   
 Created Broker__c-v1%2E1 Broker Layout      Layout                   src/force-app/main/default/layouts/Broker__c-v1%2E1 Broker Layout.layout-meta.xml                            
 Changed Property__c-Property Layout         Layout                   src/force-app/main/default/layouts/Property__c-Property Layout.layout-meta.xml                               
 Created barcodeScanner                      LightningComponentBundle src/force-app/main/default/lwc/barcodeScanner/barcodeScanner.html                                            
 Created barcodeScanner                      LightningComponentBundle src/force-app/main/default/lwc/barcodeScanner/barcodeScanner.js                                              
 Created barcodeScanner                      LightningComponentBundle src/force-app/main/default/lwc/barcodeScanner/barcodeScanner.js-meta.xml                                     
 Created brokerCard                          LightningComponentBundle src/force-app/main/default/lwc/brokerCard/brokerCard.html                                                    
 Created brokerCard                          LightningComponentBundle src/force-app/main/default/lwc/brokerCard/brokerCard.js                                                      
 Created brokerCard                          LightningComponentBundle src/force-app/main/default/lwc/brokerCard/brokerCard.js-meta.xml                                             
 Created daysOnMarket                        LightningComponentBundle src/force-app/main/default/lwc/daysOnMarket/daysOnMarket.css                                                 
 Created daysOnMarket                        LightningComponentBundle src/force-app/main/default/lwc/daysOnMarket/daysOnMarket.html                                                
 Created daysOnMarket                        LightningComponentBundle src/force-app/main/default/lwc/daysOnMarket/daysOnMarket.js                                                  
 Created daysOnMarket                        LightningComponentBundle src/force-app/main/default/lwc/daysOnMarket/daysOnMarket.js-meta.xml                                         
 Created errorPanel                          LightningComponentBundle src/force-app/main/default/lwc/errorPanel/errorPanel.js                                                      
 Created errorPanel                          LightningComponentBundle src/force-app/main/default/lwc/errorPanel/errorPanel.js-meta.xml                                             
 Created errorPanel                          LightningComponentBundle src/force-app/main/default/lwc/errorPanel/templates/inlineMessage.html                                       
 Created errorPanel                          LightningComponentBundle src/force-app/main/default/lwc/errorPanel/templates/noDataIllustration.html                                  
 Created ldsUtils                            LightningComponentBundle src/force-app/main/default/lwc/ldsUtils/ldsUtils.js                                                          
 Created ldsUtils                            LightningComponentBundle src/force-app/main/default/lwc/ldsUtils/ldsUtils.js-meta.xml                                                 
 Created navigateToRecord                    LightningComponentBundle src/force-app/main/default/lwc/navigateToRecord/navigateToRecord.html                                        
 Created navigateToRecord                    LightningComponentBundle src/force-app/main/default/lwc/navigateToRecord/navigateToRecord.js                                          
 Created navigateToRecord                    LightningComponentBundle src/force-app/main/default/lwc/navigateToRecord/navigateToRecord.js-meta.xml                                 
 Created paginator                           LightningComponentBundle src/force-app/main/default/lwc/paginator/paginator.html                                                      
 Created paginator                           LightningComponentBundle src/force-app/main/default/lwc/paginator/paginator.js                                                        
 Created paginator                           LightningComponentBundle src/force-app/main/default/lwc/paginator/paginator.js-meta.xml                                               
 Created propertyCarousel                    LightningComponentBundle src/force-app/main/default/lwc/propertyCarousel/propertyCarousel.html                                        
 Created propertyCarousel                    LightningComponentBundle src/force-app/main/default/lwc/propertyCarousel/propertyCarousel.js                                          
 Created propertyCarousel                    LightningComponentBundle src/force-app/main/default/lwc/propertyCarousel/propertyCarousel.js-meta.xml                                 
 Created propertyFilter                      LightningComponentBundle src/force-app/main/default/lwc/propertyFilter/propertyFilter.html                                            
 Created propertyFilter                      LightningComponentBundle src/force-app/main/default/lwc/propertyFilter/propertyFilter.js                                              
 Created propertyFilter                      LightningComponentBundle src/force-app/main/default/lwc/propertyFilter/propertyFilter.js-meta.xml                                     
 Created propertyLocation                    LightningComponentBundle src/force-app/main/default/lwc/propertyLocation/propertyLocation.html                                        
 Created propertyLocation                    LightningComponentBundle src/force-app/main/default/lwc/propertyLocation/propertyLocation.js                                          
 Created propertyLocation                    LightningComponentBundle src/force-app/main/default/lwc/propertyLocation/propertyLocation.js-meta.xml                                 
 Created propertyMap                         LightningComponentBundle src/force-app/main/default/lwc/propertyMap/propertyMap.html                                                  
 Created propertyMap                         LightningComponentBundle src/force-app/main/default/lwc/propertyMap/propertyMap.js                                                    
 Created propertyMap                         LightningComponentBundle src/force-app/main/default/lwc/propertyMap/propertyMap.js-meta.xml                                           
 Created propertySummary                     LightningComponentBundle src/force-app/main/default/lwc/propertySummary/propertySummary.html                                          
 Created propertySummary                     LightningComponentBundle src/force-app/main/default/lwc/propertySummary/propertySummary.js                                            
 Created propertySummary                     LightningComponentBundle src/force-app/main/default/lwc/propertySummary/propertySummary.js-meta.xml                                   
 Created propertyTile                        LightningComponentBundle src/force-app/main/default/lwc/propertyTile/propertyTile.css                                                 
 Created propertyTile                        LightningComponentBundle src/force-app/main/default/lwc/propertyTile/propertyTile.html                                                
 Created propertyTile                        LightningComponentBundle src/force-app/main/default/lwc/propertyTile/propertyTile.js                                                  
 Created propertyTile                        LightningComponentBundle src/force-app/main/default/lwc/propertyTile/propertyTile.js-meta.xml                                         
 Created propertyTileList                    LightningComponentBundle src/force-app/main/default/lwc/propertyTileList/propertyTileList.css                                         
 Created propertyTileList                    LightningComponentBundle src/force-app/main/default/lwc/propertyTileList/propertyTileList.html                                        
 Created propertyTileList                    LightningComponentBundle src/force-app/main/default/lwc/propertyTileList/propertyTileList.js                                          
 Created propertyTileList                    LightningComponentBundle src/force-app/main/default/lwc/propertyTileList/propertyTileList.js-meta.xml                                 
 Created sampleDataImporter                  LightningComponentBundle src/force-app/main/default/lwc/sampleDataImporter/sampleDataImporter.html                                    
 Created sampleDataImporter                  LightningComponentBundle src/force-app/main/default/lwc/sampleDataImporter/sampleDataImporter.js                                      
 Created sampleDataImporter                  LightningComponentBundle src/force-app/main/default/lwc/sampleDataImporter/sampleDataImporter.js-meta.xml                             
 Created FiltersChange                       LightningMessageChannel  src/force-app/main/default/messageChannels/FiltersChange.messageChannel-meta.xml                             
 Created PropertySelected                    LightningMessageChannel  src/force-app/main/default/messageChannels/PropertySelected.messageChannel-meta.xml                          
 Created Broker__c.All                       ListView                 src/force-app/main/default/objects/Broker__c/listViews/All.listView-meta.xml                                 
 Created Broker__c.All                       ListView                 src/force-app/main/default/objects/Broker__c/listViews/All.listView-meta.xml                                 
 Created Property__c.All                     ListView                 src/force-app/main/default/objects/Property__c/listViews/All.listView-meta.xml                               
 Created Property__c.All                     ListView                 src/force-app/main/default/objects/Property__c/listViews/All.listView-meta.xml                               
 Created dreamhouse                          PermissionSet            src/force-app/main/default/permissionsets/dreamhouse.permissionset-meta.xml                                  
 Created Property                            Prompt                   src/force-app/main/default/prompts/Property.prompt-meta.xml                                                  
 Created PropertyExplorer                    Prompt                   src/force-app/main/default/prompts/PropertyExplorer.prompt-meta.xml                                          
 Created PropertyFinder                      Prompt                   src/force-app/main/default/prompts/PropertyFinder.prompt-meta.xml                                            
 Created nominatim_openstreetmap             RemoteSiteSetting        src/force-app/main/default/remoteSiteSettings/nominatim_openstreetmap.remoteSite-meta.xml                    
 Created leaflet                             StaticResource           src/force-app/main/default/staticresources/leaflet.resource                                                  
 Created leaflet                             StaticResource           src/force-app/main/default/staticresources/leaflet.resource-meta.xml                                         
 Created sample_data_brokers                 StaticResource           src/force-app/main/default/staticresources/sample_data_brokers.json                                          
 Created sample_data_brokers                 StaticResource           src/force-app/main/default/staticresources/sample_data_brokers.resource-meta.xml                             
 Created sample_data_contacts                StaticResource           src/force-app/main/default/staticresources/sample_data_contacts.json                                         
 Created sample_data_contacts                StaticResource           src/force-app/main/default/staticresources/sample_data_contacts.resource-meta.xml                            
 Created sample_data_properties              StaticResource           src/force-app/main/default/staticresources/sample_data_properties.json                                       
 Created sample_data_properties              StaticResource           src/force-app/main/default/staticresources/sample_data_properties.resource-meta.xml                          

dreamhouse-lwc on  main is 📦 v1.0.0 via  v17.7.1 on ☁️  (us-east-2) took 48s 
❯ sfdx force:source:pull -u dreamhouse-lwc-test-2
Updating source tracking... done
=== Retrieved Source

 STATE   FULL NAME                      TYPE   PROJECT PATH                                                                       
 ─────── ────────────────────────────── ────── ────────────────────────────────────────────────────────────────────────────────── 
 Created Broker__c-v1%2E1 Broker Layout Layout src/unpackaged/main/default/layouts/Broker__c-v1%2E1 Broker Layout.layout-meta.xml 

dreamhouse-lwc on  main [?] is 📦 v1.0.0 via  v17.7.1 on ☁️  (us-east-2) took 4s 
❯ git status
On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
    src/unpackaged/

nothing added to commit but untracked files present (use "git add" to track)

iowillhoit commented 2 years ago

Excellent reproduction steps 🏆 Thank you @ChloeCoon! I was able to see the same result, I will get a ticket created and we'll look into it.

git2gus[bot] commented 2 years ago

This issue has been linked to a new work item: W-11658886

shetzel commented 1 year ago

This should be fixed in the current release candidate version of the sf v2 CLI. The issue is that Layouts and Profiles allow naming things with any character and it affects the API names returned by the metadata API (returned encoded), but they are not encoded in source tracking. This made it so that source tracking couldn't match existing metadata files so it would add them as new files in the default package directory.

forcedotcom / cli