forcedotcom / cli

Salesforce CLI
https://developer.salesforce.com/docs/atlas.en-us.sfdx_cli_reference.meta/sfdx_cli_reference/
BSD 3-Clause "New" or "Revised" License
493 stars 78 forks source link

Some classes out of date with sfdx-project.json schema #2201

Closed jonnypetraglia closed 5 months ago

jonnypetraglia commented 3 years ago

Summary

From what I can see, the schema has been updated but not the class, which is causing Typescript to have a fit. Specifically in our custom plugin and specifically for apexTestAccess, though I noticed that others are also missing as well like unpackagedMetadata.

The PackageDir class the code is using is @salesforce\core\lib\sfdxProject.d.ts

Steps To Reproduce:

Reference apexTestAccess on a PackageDir object

Expected result

No syntax error

Actual result

Syntax error

Additional information

image

image

SFDX CLI Version sfdx-cli/7.118.1 win32-x64 node-v14.17.4

SFDX plugin Version: @oclif/plugin-autocomplete 0.3.0 (core) @oclif/plugin-commands 1.3.0 (core) @oclif/plugin-help 3.2.3 (core) @oclif/plugin-not-found 1.2.4 (core) @oclif/plugin-plugins 1.10.1 (core) @oclif/plugin-update 1.4.0-3 (core) @oclif/plugin-warn-if-update-available 1.7.0 (core) @oclif/plugin-which 1.0.3 (core) @salesforce/sfdx-diff 0.0.6 @salesforce/sfdx-plugin-lwc-test 0.1.7 (core) alias 1.1.10 (core) apex 0.2.8 (core) auth 1.7.1 (core) config 1.2.34 (core) custom-metadata 1.0.12 (core) data 0.6.1 (core) generator 1.2.0 (core) limits 1.2.1 (core) mo-dx-plugin 0.3.2 org 1.7.0 (core) plugin-lightning-testing-service 1.0.1 salesforce-alm 52.3.3 (core) schema 1.0.8 (core) sfdx-cli 7.118.1 (core) sfdx-git-delta 4.9.0 sfdx-git-packager 0.3.3 sfdx-isdot 2.7.0 (link) C:\Users\jpetraglia\repos\isdot sfdx-jayree 3.11.2 └─ @jayree/sfdx-plugin-prettier 1.0.4 source 1.0.15 (core) telemetry 1.2.3 (core) templates 52.1.0 (core) texei-sfdx-plugin 1.10.1 trust 1.0.7 (core) user 1.4.0 (core)

OS and version: Windows 10

jonnypetraglia commented 2 years ago

Bumping on this as it's almost been 2 weeks.

This is causing issues with new versions of our plugin able to be packed. What would be a timeline for adding this?

jonnypetraglia commented 2 years ago

Bumping on this as another week has passed.

Apologies if I'm being aggressive but, as far as I know, this is not a new feature, this has been something available in SFDX for quite some time, so I'm wondering why this hasn't been prioritized.

mshanemc commented 2 years ago

Thanks for the pings--we don't get a lot of issues on this library so sorry for not paying closer attention to it.

You're right about it missing some properties--those usually get added as we need them (and not always as the are created in the schema).

Are you just wanting us to add the properties on the types here? https://github.com/forcedotcom/sfdx-core/blob/e8c5e79f6039970ce72945abad7e9b4bcb13a51b/src/sfdxProject.ts#L29

jonnypetraglia commented 2 years ago

You are correct, sir!

git2gus[bot] commented 1 year ago

This issue has been linked to a new work item: W-13565856

jshackell-sfdc commented 5 months ago

This issue is fixed in the 2.42.6 (May 22, 2024) release.