No indication of failure until the end of deploy logs

forcedotcom / cli

Salesforce CLI

https://developer.salesforce.com/docs/atlas.en-us.sfdx_cli_reference.meta/sfdx_cli_reference/

BSD 3-Clause "New" or "Revised" License

494 stars 78 forks source link

No indication of failure until the end of deploy logs #3104

Open andrewgoodmansabio opened 3 days ago

andrewgoodmansabio commented 3 days ago

Following on from Changes to deploy output? #3079, I see that the new console output is back in the latest build.

The logging is improved from the previous iteration but no longer shows any indication of an error until the build has finished.

Before example:

After example:

The previous logging wasn't great, it didn't say what the error was but we'd know the build had failed. The newer version doesn't even give us this information.

In earlier builds of SFDX, you'd get the whole component/test failure output as soon as it happened - it wasn't necessarily pretty but it was functional and gave us the information.

This is important. Salesforce builds can run for ages, with some clients hours - developers need to know about these failures as soon as they happen so that they can be working on fixes whilst the rest of the build completes.

Note, developers don't necessarily have access to the orgs where validations are running - the only thing they have to go on is the logs.

github-actions[bot] commented 3 days ago

Hello @andrewgoodmansabio :wave: It looks like you didn't include the full Salesforce CLI version information in your issue. Please provide the output of version --verbose --json for the CLI you're using (sf or sfdx).

A few more things to check:

Make sure you've provided detailed steps to reproduce your issue.
- A repository that clearly demonstrates the bug is ideal.
Make sure you've installed the latest version of Salesforce CLI. (docs)
- Better yet, try the rc or nightly versions. (docs)
Try running the doctor command to diagnose common issues.
Search GitHub for existing related issues.

Thank you!

github-actions[bot] commented 3 days ago

Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support.

git2gus[bot] commented 2 days ago

This issue has been linked to a new work item: W-17203886

cristiand391 commented 1 day ago

@andrewgoodmansabio thanks for the heads up, we got a PR to add a completed/failed counter here: https://github.com/salesforcecli/plugin-deploy-retrieve/pull/1215

In earlier builds of SFDX, you'd get the whole component/test failure output as soon as it happened - it wasn't necessarily pretty but it was functional and gave us the information.

agree, asked my team about ways we can render failures as soon as they appear while polling for the deploy status.