SFDX CLI for Windows ERROR: Cannot read property 'fileName' of undefined. for AuraDefinitionBundle

GregFinzer commented 5 years ago

Summary

I am receiving the error: ERROR: Cannot read property 'fileName' of undefined.

Steps To Reproduce:

Define this package.xml

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>*</members>
        <name>AuraDefinitionBundle</name>
    </types>
    <version>45.0</version>
</Package>

Run this command: sfdx force:source:retrieve --manifest c:\_hilton\BossReno\manifest\package.xml

Expected result

The source should be retrieved

Actual result

ERROR: Cannot read property 'fileName' of undefined.

Additional information

The development environment is Salesforce Spring 2019

I have posted these questions on the forums: https://salesforce.stackexchange.com/questions/251431/sfdx-error-cannot-read-property-filename-of-undefined/251569#251569

https://developer.salesforce.com/forums/ForumsMain?id=9062I000000QuEcQAK

All other nodes in the package.xml are working fine. Only the AuraDefinitionBundle is not working. I figured this out through process of elimination.

Here is my full package.xml

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>*</members>
        <name>ApexClass</name>
    </types>
    <types>
        <members>*</members>
        <name>ApexComponent</name>
    </types>
    <types>
        <members>*</members>
        <name>ApexPage</name>
    </types>
    <types>
        <members>*</members>
        <name>ApexTestSuite</name>
    </types>
    <types>
        <members>*</members>
        <name>ApexTrigger</name>
    </types>
    <types>
        <members>*</members>
        <name>AuraDefinitionBundle</name>
    </types>
    <types>
        <members>*</members>
        <name>StaticResource</name>
    </types>
    <version>45.0</version>
</Package>

SFDX CLI Version(to find the version of the CLI engine run sfdx --version): sfdx-cli/6.54.4-c01dcc69db (windows-x64) node-v8.9.4

SFDX plugin Version(to find the version of the CLI plugin run sfdx plugins --core)

@salesforce/plugin-generator 1.0.1 (core) @salesforce/sfdx-trust 2.0.1 (core) builtins 1.0.0 (core) salesforcedx 45.3.4

OS and version: Windows 10 Pro

clairebianchi commented 5 years ago

@GregFinzer can you update your Salesforce CLI and retest?

GregFinzer commented 5 years ago

@clairebianchi It looks like there was a problem with the deployment. I did a sfdx update and it gave me the message: Updating CLI... already on latest version: 6.55.1-be0b3dc4c4

I tried doing the same command again in VS Code: sfdx force:source:retrieve --manifest c:\_hilton\BossReno\manifest\package.xml

Here was the response:

ERROR:  Cannot read property 'fileName' of undefined.
08:59:31.188 sfdx force:source:retrieve --manifest c:\_hilton\BossReno\manifest\package.xml ended with exit code 1

Here is the package.xml file that I used:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>*</members>
        <name>ApexClass</name>
    </types>
    <types>
        <members>*</members>
        <name>ApexComponent</name>
    </types>
    <types>
        <members>*</members>
        <name>ApexPage</name>
    </types>
    <types>
        <members>*</members>
        <name>ApexTestSuite</name>
    </types>
    <types>
        <members>*</members>
        <name>ApexTrigger</name>
    </types>
    <types>
        <members>*</members>
        <name>StaticResource</name>
    </types>
    <types>
        <members>*</members>
        <name>AuraDefinitionBundle</name>
    </types>    
    <version>45.0</version>
</Package>

shetzel commented 5 years ago

@GregFinzer - If you look at your list of plugins, salesforcedx is at version 45.3.4, which is not the most recent. This means you probably installed a specific version of the salesforcedx plugin at some point. The bug you are hitting was fixed in a later version of the plugin (45.7.1 iirc). You should uninstall that version of the salesforcedx plugin and use the core version that ships with the CLI. Run sfdx plugins:uninstall salesforcedx. If you then run sfdx plugins --core it should display salesforcedx (core). Run the force:source:retrieve command again and you should no longer see that bug.

Ramondi commented 5 years ago

@shetzel I had the exact same issue and running the commands you mentioned I was able to run a retrieve without any problem. Thanks mate!

GregFinzer commented 5 years ago

@shetzel Those steps did not work for me. I also did a full uninstall of salesforce cli, reboot, and then re-install. I also tried the command again:

sfdx plugins:uninstall salesforcedx

Result salesforcedx is not installed

When I do this: sfdx plugins --core

I get this:

@salesforce/plugin-generator 1.0.1 (core)
@salesforce/sfdx-trust 2.0.1 (core)
builtins 1.0.0 (core)
salesforcedx 45.4.1 (core)

shetzel commented 5 years ago

@GregFinzer - Your cli and plugin versions look correct now. Your package.xml also looks good. The next thing to check is if you're locked to an older API version. Look in your sfdx-project.json for sourceApiVersion and if it's set to less than "45.0" then either update it to "45.0" or remove it. Also, append --dev-debug to your sfdx force:source:retrieve command to get lots of debugging output and a stack trace for that error. I'm expecting the stack trace to be identical to a previous bug but if not, maybe we have a new bug on our hands.

Thanks for your patience and all the info in your posts. It really helps when solving problems like this.

GregFinzer commented 5 years ago

@shetzel No problem, I am usually on the other end of the support so I am paying it forward. :smile:

Here is my sfdx-project.json

{
  "packageDirectories": [
    {
      "path": "force-app",
      "default": true
    }
  ],
  "namespace": "",
  "sfdcLoginUrl": "https://login.salesforce.com",
  "sourceApiVersion": "45.0"
}

Here is the stack trace. Notice it takes 7 minutes :open_mouth: to get to the error:

C:\_hilton\BossReno>sfdx force:source:retrieve --manifest --dev-debug c:\_hilton\BossReno\manifest\package.xml
  cli starting run +0ms
  cli checking autoupdater +64ms
  rwlockfile read C:\Users\greg.finzer\AppData\Local\sfdx\update.lock +0ms
  cli-engine:hooks init C:\Program Files\Salesforce CLI\client\dist\hooks\plugins\migrate.js +0ms
  sfdx:hook:init:plugins:migrate enter +0ms
  sfdx:plugins:migrate no v5 plugins need migration +0ms
  sfdx:hook:init:plugins:migrate exit +2ms
  cli dispatcher +139ms
  cli-engine:hooks plugins:parse C:\Program Files\Salesforce CLI\client\dist\hooks\plugins\convertFromV5.js +3s
  sfdx:hook:plugins:parse:legacy enter +0ms
  sfdx:hook:plugins:parse:legacy exit +0ms
  cli-engine:hooks plugins:parse C:\Program Files\Salesforce CLI\client\dist\hooks\plugins\convertFromV5.js +14ms
  sfdx:hook:plugins:parse:legacy enter +6ms
  sfdx:hook:plugins:parse:legacy exit +2ms
  cli-engine:hooks prerun C:\Program Files\Salesforce CLI\client\dist\hooks\logAnalytics.js +4ms
  sfdx:hook:analytics enter +0ms
  sfdx:analytics setting up exit handler +0ms
  sfdx:hook:analytics exit +0ms
  cli running flow command { _version: '9.0.7' } +3s
(node:6748) DeprecationWarning: this.out and this.cli is deprecated. Please import the "cli-ux" module directly instead.
(node:6748) DeprecationWarning: cli.color is deprecated. Please use `import color from '@heroku-cli/color'` instead.
  sfdx:core TRACE Setup child 'Org' logger instance +0ms
  sfdx:core TRACE Setup child 'SourceRetrieve' logger instance +13ms
  sfdx:core TRACE Setup child 'SourceUtil' logger instance +8s
  sfdx:SourceUtil INFO Created output directory 'C:\Users\GREG~1.FIN\AppData\Local\Temp\sdx_sourceRetrieve_1551982203207' +0ms
  sfdx:SourceRetrieve INFO Retrieving metadata in manifest 'c:\_hilton\BossReno\manifest\package.xml' from org: 'greg.finzer@dynamit.com.bossdyn' +0ms
  sfdx:core TRACE Setup child 'SourceUtil' logger instance +6m
ERROR:  Cannot read property 'fileName' of undefined.
ERROR:
*** Internal Diagnostic ***

TypeError: Cannot read property 'fileName' of undefined
    at Function.getMetadataFileNameFromBundleFileProperties (C:\Program Files\Salesforce CLI\client\node_modules\salesforce-alm\dist\lib\bundlePathHelper.js:27:48)
    at Function.getPathFromBundleTypeFileProperties (C:\Program Files\Salesforce CLI\client\node_modules\salesforce-alm\dist\lib\bundlePathHelper.js:20:43)
    at AuraDefinitionBundleMetadataType.getDefaultAggregateMetadataPath (C:\Program Files\Salesforce CLI\client\node_modules\salesforce-alm\dist\lib\metadataTypeImpl\bundleMetadataType.js:28:52)
    at SourceWorkspaceAdapter.processMdapiFileProperty (C:\Program Files\Salesforce CLI\client\node_modules\salesforce-alm\dist\lib\sourceWorkspaceAdapter.js:223:55)
    at result.fileProperties.forEach (C:\Program Files\Salesforce CLI\client\node_modules\salesforce-alm\dist\lib\mdapiPullApi.js:132:22)
    at Array.forEach (<anonymous>)
    at MdapiPullApi._syncDownSource (C:\Program Files\Salesforce CLI\client\node_modules\salesforce-alm\dist\lib\mdapiPullApi.js:125:31)
    at SourceRetrieve.<anonymous> (C:\Program Files\Salesforce CLI\client\node_modules\salesforce-alm\dist\lib\source\sourceRetrieve.js:111:56)
    at Generator.next (<anonymous>)
    at fulfilled (C:\Program Files\Salesforce CLI\client\node_modules\salesforce-alm\dist\lib\source\sourceRetrieve.js:10:58)
    at <anonymous>
******

  cli flushing stdout +7m
  sfdx:analytics using C:\Users\greg.finzer\AppData\Local\sfdx\analytics.log for usage error logging +7m
  sfdx:analytics spawned usage "C:\Program Files\Salesforce CLI\client\bin\node.exe C:\Program Files\Salesforce CLI\client\dist\processes\logUsage" +18ms

shetzel commented 5 years ago

I'll reopen this issue until it's resolved. I'm not able to repro this on my windows VM but my file paths are not exactly the same as yours and that is most likely the issue. I'll continue to try to repro but in the meantime I'll give you some things to try.

Unless you're retrieving hundreds of metadata and/or have a very, very large project 7 minutes for a retrieve is ridiculous. Be sure you are excluding C:\Program Files\Salesforce CLI and the sfdx executable from Windows Defender or any other antivirus program. It makes a huge difference in command runtime.
Are you able to use sfdx force:mdapi:retrieve then sfdx force:mdapi:convert as a workaround for retrieving your aura bundles? Although that is essentially what sfdx force:source:retrieve is doing for you it's a slightly different code path when done this way.
So I can reproduce this more exactly, (and if you're comfortable doing so) what is the full path to your aura bundles, including bundle name. E.g., C:\_hilton\BossReno\force-app\main\default\aura\MyAuraBundle1\ If you'd rather not post this info that's ok. I'm mostly looking for special characters or anything else non-standard anywhere in the file path.
If you feel comfortable doing so, please modify C:\Program Files\Salesforce CLI\client\node_modules\salesforce-alm\dist\lib\bundlePathHelper.js line 25 (in the getMetadataFileNameFromBundleFileProperties method) to console log the function args. E.g., console.log('fullName=', fullName); console.log('bundleFileTypeProperties=', bundleFileTypeProperties); Then run your sfdx force:source:retrieve command again and note those logged values.

GregFinzer commented 5 years ago

We have a critical client demo tomorrow that I am preparing for. I will most likely get to this on Monday.

GregFinzer commented 5 years ago

@shetzel

Yes, it is a very large project. I did a file properties and it is around 7000 files. Although I am not sure how many files are just simply files created by sfdx for the typings.
I tried sfdx force:mdapi:retrieve. I waited for about 20 minutes and it never came back.
There is no aura sub folders since I cannot retrieve. I do have an underscore in the folder name at the beginning. The main path is this: C:_hilton\BossReno\force-app\main\default\aura
I modified the JavaScript file and re-ran. Here is the result:

C:_hilton\BossReno>sfdx force:source:retrieve --manifest --dev-debug c:_hilton\BossReno\manifest\package.xml cli starting run +0ms cli checking autoupdater +67ms rwlockfile read C:\Users\greg.finzer\AppData\Local\sfdx\update.lock +0ms cli-engine:hooks init C:\Users\greg.finzer\AppData\Local\sfdx\client\dist\hooks\plugins\migrate.js +0ms sfdx:hook:init:plugins:migrate enter +0ms sfdx:plugins:migrate no v5 plugins need migration +0ms sfdx:hook:init:plugins:migrate exit +0ms cli dispatcher +133ms cli-engine:hooks plugins:parse C:\Users\greg.finzer\AppData\Local\sfdx\client\dist\hooks\plugins\convertFromV5.js +3s sfdx:hook:plugins:parse:legacy enter +0ms sfdx:hook:plugins:parse:legacy exit +0ms cli-engine:hooks plugins:parse C:\Users\greg.finzer\AppData\Local\sfdx\client\dist\hooks\plugins\convertFromV5.js +16ms sfdx:hook:plugins:parse:legacy enter +16ms sfdx:hook:plugins:parse:legacy exit +0ms cli-engine:hooks prerun C:\Users\greg.finzer\AppData\Local\sfdx\client\dist\hooks\logAnalytics.js +4ms sfdx:hook:analytics enter +0ms sfdx:analytics setting up exit handler +0ms sfdx:hook:analytics exit +0ms cli running flow command { _version: '9.0.7' } +3s (node:25512) DeprecationWarning: this.out and this.cli is deprecated. Please import the "cli-ux" module directly instead. (node:25512) DeprecationWarning: cli.color is deprecated. Please use import color from '@heroku-cli/color' instead. sfdx:core TRACE Setup child 'Org' logger instance +0ms sfdx:core TRACE Setup child 'SourceRetrieve' logger instance +0ms sfdx:core TRACE Setup child 'SourceUtil' logger instance +9s sfdx:SourceUtil INFO Created output directory 'C:\Users\GREG~1.FIN\AppData\Local\Temp\sdx_sourceRetrieve_1552394161160' +0ms sfdx:SourceRetrieve INFO Retrieving metadata in manifest 'c:_hilton\BossReno\manifest\package.xml' from org: 'greg.finzer@dynamit.com.bossdyn' +0ms sfdx:core TRACE Setup child 'SourceUtil' logger instance +37s ERROR: Cannot read property 'fileName' of undefined. ERROR: Internal Diagnostic

TypeError: Cannot read property 'fileName' of undefined at Function.getMetadataFileNameFromBundleFileProperties (C:\Users\greg.finzer\AppData\Local\sfdx\client\node_modules\salesforce-alm\dist\lib\bundlePathHelper.js:27:48) at Function.getPathFromBundleTypeFileProperties (C:\Users\greg.finzer\AppData\Local\sfdx\client\node_modules\salesforce-alm\dist\lib\bundlePathHelper.js:20:43) at AuraDefinitionBundleMetadataType.getDefaultAggregateMetadataPath (C:\Users\greg.finzer\AppData\Local\sfdx\client\node_modules\salesforce-alm\dist\lib\metadataTypeImpl\bundleMetadataType.js:28:52) at SourceWorkspaceAdapter.processMdapiFileProperty (C:\Users\greg.finzer\AppData\Local\sfdx\client\node_modules\salesforce-alm\dist\lib\sourceWorkspaceAdapter.js:223:55) at result.fileProperties.forEach (C:\Users\greg.finzer\AppData\Local\sfdx\client\node_modules\salesforce-alm\dist\lib\mdapiPullApi.js:132:22) at Array.forEach () at MdapiPullApi._syncDownSource (C:\Users\greg.finzer\AppData\Local\sfdx\client\node_modules\salesforce-alm\dist\lib\mdapiPullApi.js:125:31) at SourceRetrieve. (C:\Users\greg.finzer\AppData\Local\sfdx\client\node_modules\salesforce-alm\dist\lib\source\sourceRetrieve.js:111:56) at Generator.next () at fulfilled (C:\Users\greg.finzer\AppData\Local\sfdx\client\node_modules\salesforce-alm\dist\lib\source\sourceRetrieve.js:10:58) at

cli flushing stdout +46s sfdx:analytics using C:\Users\greg.finzer\AppData\Local\sfdx\analytics.log for usage error logging +46s sfdx:analytics spawned usage "C:\Users\greg.finzer\AppData\Local\sfdx\client\bin\node.exe C:\Users\greg.finzer\AppData\Local\sfdx\client\dist\processes\logUsage" +16ms

shetzel commented 5 years ago

@GregFinzer - Your last post has a different stack trace that points to different plugin code. It looks like you may have been auto-updated to a more recent version in between the first stack trace and your most recent stack trace. So I don't see the console.log output from the modified js because it didn't use that source when running the command. Next chance you get can you run the command again, get the stack trace, then look at the top file and modify that file in the same place. It should be this file: C:\Users\greg.finzer\AppData\Local\sfdx\client\node_modules\salesforce-alm\dist\lib\bundlePathHelper.js. Add those console logs, re-run the command and send what the values are for fullName and bundleFileTypeProperties. Thanks!

GregFinzer commented 5 years ago

@shetzel the file still had the logging statements even after the update. Here is the method with the modified code:

static getMetadataFileNameFromBundleFileProperties(fullName, bundleFileTypeProperties) { console.log('fullName=', fullName); console.log('bundleFileTypeProperties=', bundleFileTypeProperties); const bundleName = fullName.split(path.sep)[0]; const matchingBundle = bundleFileTypeProperties.find(fileProperty => fileProperty.fullName.split(path.sep)[0] === bundleName); return${path.basename(matchingBundle.fileName)}${MetadataRegistry.getMetadataFileExt()}; }

shetzel commented 5 years ago

@GregFinzer - right but that's the file from the original install. When you update to a newer version of the cli the files are in a different location. You need to modify bundlePathHelper.js in that location because those are the files used when you run the commands after a cli update. Your modified code looks perfect. You just need to make the same modification to C:\Users\greg.finzer\AppData\Local\sfdx\client\node_modules\salesforce-alm\dist\lib\bundlePathHelper.js. After you do that, then run your command from within your project and send the values of fullName and bundleFileTypeProperties.

sfdx force:source:retrieve --manifest c:_hilton\BossReno\manifest\package.xml

no-response[bot] commented 5 years ago

This issue has been automatically closed because there has been no response to our request for more information from the original author. Currently, there is not enough information provided for us to take action. Please reply and reopen this issue if you need additional assistance.

GregFinzer commented 5 years ago

That path does not exist on my machine.