.forceignore v2 warning when ignoring **/README.md

lukecotter commented 3 years ago

Summary

Received this warning when trying to run force:source:push, the push is successful I just get a warning.

(node:3085) Warning: The .forceignore file doesn't adhere to .gitignore format which will be the default behavior starting in Spring '21 release. More information on .gitignore format here: https://git-scm.com/docs/gitignore. Fix the following lines in your .forceignore and add '# .forceignore v2' to your .forceignore file to switch to the new behavior. (Usenode --trace-warnings ...to show where the warning was created) (node:3085) Warning: **/README.md

The ignore pattern in use was to ignore all README.md files in all dirs.

Steps To Reproduce:

Create a project with a README.md file
Add **/README.md to .forceignore
Useforce:source:push
You will get the error

Expected result

Seem like it is a valid ignore pattern based on git ignore, so no warning should be seen.

Actual result

I get this error instead.

(node:3085) Warning: The .forceignore file doesn't adhere to .gitignore format which will be the default behavior starting in Spring '21 release. More information on .gitignore format here: https://git-scm.com/docs/gitignore. Fix the following lines in your .forceignore and add '# .forceignore v2' to your .forceignore file to switch to the new behavior. (Usenode --trace-warnings ...to show where the warning was created) (node:3085) Warning: **/README.md

SFDX CLI Version(to find the version of the CLI engine run sfdx --version): SFDX plugin Version(to find the version of the CLI plugin run sfdx plugins --core)

OS and version: MacOS Big Sur: 11.2 (20D64)

github-actions[bot] commented 3 years ago

Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support.

uip-robot-zz commented 3 years ago

This issue has been linked to a new work item: W-9051899

github-actions[bot] commented 3 years ago

Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support.

github-actions[bot] commented 3 years ago

Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support.

mshanemc commented 3 years ago

https://github.com/forcedotcom/cli/blob/main/releasenotes/README.md#51140-may-27-2021---cli-71030

lukecotter commented 3 years ago

I still see the warning when pushing, the push works though. forceignore is set to v2.

here is the warning on latest cli

and the versions

gfmmoreira commented 3 years ago

@mshanemc I am also facing this issue while adding a README.md file to forceIgnore.

Below are the lines which are triggering the warning:

# Unpackaged
**/unpackaged/README.md

The output of sfdx plugins:

@salesforce/sfdx-diff 0.0.6
@salesforce/sfdx-scanner 2.11.0
salesforcedx 52.0.0
├─ data 0.4.11
├─ apex 0.2.2
├─ limits 1.2.1
├─ custom-metadata 1.0.12
├─ schema 1.0.7
├─ user 1.3.0
├─ @salesforce/sfdx-plugin-lwc-test 0.1.7
├─ org 1.6.6
├─ templates 51.5.0
└─ salesforce-alm 52.0.0

And the output of sfdx --version:

sfdx-cli/7.114.0 darwin-x64 node-v14.17.5

The lines seem to be adhering the gitignore format as mentioned by @lukecotter, so no apparent reason for the warning message to appear.

forcedotcom / cli